From: Michael Ellerman <mpe@ellerman•id.au>
To: Hari Bathini <hbathini@linux•vnet.ibm.com>,
Mahesh J Salgaonkar <mahesh@linux•vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@ozlabs•org>
Subject: Re: [PATCH 1/2] powerpc/fadump: reserve memory at halfway mark
Date: Fri, 10 Mar 2017 21:44:33 +1100 [thread overview]
Message-ID: <87zigtjtri.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <148907087368.3574.8071537539290192784.stgit@hbathini.in.ibm.com>
Hari Bathini <hbathini@linux•vnet.ibm.com> writes:
> Currently, the area to preserve boot memory is reserved at the top of
> RAM. This leaves fadump vulnerable to DLPAR memory remove operations.
> As memory for fadump needs to be reserved early in the boot process,
> fadump can't be registered after a DLPAR memory remove operation.
> While this problem can't be eleminated completely, the impact can be
> minimized by reserving memory at the halfway mark instead. With this
> change, fadump can register successfully after a DLPAR memory remove
> operation as long as the sum of the sizes of boot memory and memory
> removed is less than half of the total available memory.
>
> Signed-off-by: Hari Bathini <hbathini@linux•vnet.ibm.com>
> ---
> arch/powerpc/kernel/fadump.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
> index 8ff0dd4..9c85c5a 100644
> --- a/arch/powerpc/kernel/fadump.c
> +++ b/arch/powerpc/kernel/fadump.c
> @@ -319,9 +319,13 @@ int __init fadump_reserve_mem(void)
> pr_debug("fadumphdr_addr = %p\n",
> (void *) fw_dump.fadumphdr_addr);
> } else {
> - /* Reserve the memory at the top of memory. */
> + /*
> + * Reserve memory at the halfway mark to minimize
> + * the impact of DLPAR memory remove operation.
> + */
> + base = PAGE_ALIGN(memory_boundary/2);
This doesn't account for holes, do we never have holes in the memory
layout on phyp?
cheers
prev parent reply other threads:[~2017-03-10 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 14:47 [PATCH 1/2] powerpc/fadump: reserve memory at halfway mark Hari Bathini
2017-03-09 14:48 ` [PATCH 2/2] powerpc/fadump: update fadump documentation Hari Bathini
2017-03-10 10:44 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zigtjtri.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=hbathini@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mahesh@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox