From: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
To: Anshuman Khandual <khandual@linux•vnet.ibm.com>,
benh@kernel•crashing.org, paulus@samba•org, mpe@ellerman•id.au,
Chris Smart <csmart@ozlabs•au.ibm.com>,
Christophe Leroy <christophe.leroy@c-s•fr>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] powerpc/mm/hugetlb: Don't panic if we don't find the default huge page size
Date: Mon, 16 Jan 2017 22:12:32 +0530 [thread overview]
Message-ID: <87ziirx8g7.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <4f38a92d-353f-d505-43c3-a2d752d22657@linux.vnet.ibm.com>
Anshuman Khandual <khandual@linux•vnet.ibm.com> writes:
> On 12/13/2016 07:34 PM, Aneesh Kumar K.V wrote:
>> generic hugetlbfs can handle that condition correctly. With HPAGE_SHIFT = 0
>
> Need to add some context here. "That condition" refers to something without
> first mentioning it.
It is the conditinal statement that gets removed as part of this patch.
The next line also explains what the generic code does for that condition.
>
>> we get
>> [0.241333] hugetlbfs: disabling because there are no supported hugepage sizes
>>
>> bash-4.2# echo 30 > /proc/sys/vm/nr_hugepages
>> bash: echo: write error: Operation not supported
>>
>> Fixes: "powerpc: get hugetlbpage handling more generic"
>
> Dont we need the commit SHA for the "Fixes" header ?
When I wrote the patch, the commit was not upstream. Hence i didn't had
an SHA1 to put there.
-aneesh
next prev parent reply other threads:[~2017-01-16 17:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 14:04 [PATCH] powerpc/mm/hugetlb: Don't panic if we don't find the default huge page size Aneesh Kumar K.V
2017-01-04 0:18 ` Michael Neuling
2017-01-16 6:55 ` Anshuman Khandual
2017-01-16 16:42 ` Aneesh Kumar K.V [this message]
2017-01-18 12:10 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ziirx8g7.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=csmart@ozlabs$(echo .)au.ibm.com \
--cc=khandual@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox