Subject: Re: [PATCH V4 15/18] powerpc/mm: Move hash page table related functions to pgtable-hash64.c

From: "Aneesh Kumar K.V" <[email-masked]>
Date: Fri, 26 Feb 2016 15:30:47 +0530

Scott Wood <[email-masked]> writes:

Hi Scott,

Thanks for testing this series.

> On Tue, 2016-02-23 at 10:18 +0530, Aneesh Kumar K.V wrote:
>> 
>> diff --git a/arch/powerpc/mm/pgtable-book3e.c b/arch/powerpc/mm/pgtable
>> -book3e.c
>> new file mode 100644
>> index 000000000000..bdaa4376f838
>> --- /dev/null
>> +++ b/arch/powerpc/mm/pgtable-book3e.c
>> @@ -0,0 +1,163 @@
>> +
>> +/*
>> + * Copyright IBM Corporation, 2015
>> + * Author Aneesh Kumar K.V <[email-masked]>
>> + *
>> + * This program is free software; you can redistribute it and/or modify it
>> + * under the terms of version 2 of the GNU Lesser General Public License
>> + * as published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it would be useful, but
>> + * WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>> + *
>> + */
>> +
>> +/*
>> + * PPC64 THP Support for hash based MMUs
>> + */
>
> This comment doesn't match the filename.
>
> Regarding the rest of the file's contents, why is this being code being
> copied?  The very terse changelog doesn't cover it.
>

While doing the cleanup/code movement, I was trying to keep nonhash code
as much closer to as it is now, because there is no way for me to test
it and I wanted to avoid any regression. I agree that in some case it is
creating confusion like above.

If we agree that some of these cleanup/code movement are helping, then I
can redo the series making sure changes like above are taken care of.

-aneesh