public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite•dk>
To: linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH] Consolidate XILINX_VIRTEX board support
Date: Tue, 07 Aug 2007 09:01:01 +0200	[thread overview]
Message-ID: <87zm13ygk2.fsf@sleipner.barco.com> (raw)
In-Reply-To: <20070806225642.7D72A7B005B@mail34-fra.bigfish.com> (Wolfgang Reissnegger's message of "Mon, 06 Aug 2007 15:57:25 -0700")

>>>>> "WR" == Wolfgang Reissnegger <wolfgang.reissnegger@xilinx•com> writes:

Hi,

WR> diff --git a/arch/ppc/boot/simple/Makefile b/arch/ppc/boot/simple/Makefile
WR> index 5b87779..05631fe 100644
WR> --- a/arch/ppc/boot/simple/Makefile
WR> +++ b/arch/ppc/boot/simple/Makefile
WR> @@ -187,8 +187,7 @@ boot-$(CONFIG_REDWOOD_6)	+= embed_config.o
WR>  boot-$(CONFIG_8xx)		+= embed_config.o
WR>  boot-$(CONFIG_8260)		+= embed_config.o
WR>  boot-$(CONFIG_EP405)		+= embed_config.o
WR> -boot-$(CONFIG_XILINX_ML300)	+= embed_config.o
WR> -boot-$(CONFIG_XILINX_ML403)	+= embed_config.o
WR> +boot-$(CONFIG_XILINX_VIRTEX)	+= embed_config.o

Don't do that. Other boards with Xilinx FPGAs don't necessarily need
embed_config.c

WR>  boot-$(CONFIG_BSEIP)		+= iic.o
WR>  boot-$(CONFIG_MBX)		+= iic.o pci.o qspan_pci.o
WR>  boot-$(CONFIG_MV64X60)		+= misc-mv64x60.o
WR> diff --git a/arch/ppc/boot/simple/embed_config.c b/arch/ppc/boot/simple/embed_config.c
WR> index 840bff2..e0b8954 100644
WR> --- a/arch/ppc/boot/simple/embed_config.c
WR> +++ b/arch/ppc/boot/simple/embed_config.c
WR> @@ -744,7 +744,7 @@ embed_config(bd_t **bdp)
WR>  }
WR>  #endif /* WILLOW */
 
WR> -#if defined(CONFIG_XILINX_ML300) || defined(CONFIG_XILINX_ML403)
WR> +#if defined(CONFIG_XILINX_VIRTEX)
WR>  void
WR>  embed_config(bd_t ** bdp)

.. And if they do, they might have another embed_config (E.G. if the
bootloader provides a valid struct bd_t).

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2007-08-07  7:21 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-06 22:57 [PATCH] Consolidate XILINX_VIRTEX board support Wolfgang Reissnegger
2007-08-06 23:24 ` Arnd Bergmann
2007-08-06 23:36   ` Stephen Neuendorffer
2007-08-06 23:41     ` Grant Likely
2007-08-09 18:54   ` Grant Likely
2007-08-10 12:22     ` Device Tree tool [was RE: [PATCH] Consolidate XILINX_VIRTEX board support] Koss, Mike (Mission Systems)
2007-08-10 13:48       ` Grant Likely
2007-08-10 15:36         ` Device Tree tool [was RE: [PATCH] Consolidate XILINX_VIRTEX boardsupport] Stephen Neuendorffer
2007-08-14 21:54           ` Device Tree tool [was RE: [PATCH] Consolidate XILINX_VIRTEXboardsupport] Stephen Neuendorffer
2007-08-15  6:41             ` Michal Simek
2007-08-15 16:14               ` Stephen Neuendorffer
2007-08-15 14:03             ` Grant Likely
2007-08-10 14:37     ` [PATCH] Consolidate XILINX_VIRTEX board support Kumar Gala
2007-08-11  4:35       ` Grant Likely
2007-08-07  7:01 ` Peter Korsgaard [this message]
2007-08-07  7:17 ` Peter Korsgaard
2007-08-09 18:57   ` Grant Likely
2007-08-10  7:17     ` Peter Korsgaard
2007-08-10 14:28       ` Grant Likely
2007-08-19  1:34   ` David H. Lynch Jr.
2007-08-19  1:57     ` Josh Boyer
2007-08-23  6:43       ` David H. Lynch Jr.
2007-08-09 18:42 ` Grant Likely
2007-08-11  4:37   ` Grant Likely
2007-08-14  2:47     ` Best Linux tree for Xilinx support Leonid
2007-08-14  5:07       ` Wolfgang Reissnegger
2007-08-14 17:28         ` Leonid
2007-08-14 17:53           ` Grant Likely
2007-08-14 20:43           ` Wolfgang Reissnegger
2007-08-14 20:47             ` Leonid
2007-08-19  1:29           ` David H. Lynch Jr.
     [not found] <11877426871932-git-send-email-w.reissnegger@gmx.net>
2007-08-22  0:31 ` [PATCH] Consolidate XILINX_VIRTEX board support Wolfgang Reissnegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zm13ygk2.fsf@sleipner.barco.com \
    --to=jacmet@sunsite$(echo .)dk \
    --cc=linuxppc-embedded@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox