From: Paul Collins <paul@briny•ondioline.org>
To: Johannes Berg <johannes@sipsolutions•net>
Cc: debian-powerpc <debian-powerpc@lists•debian.org>,
"Eddy Petrişor" <eddy.petrisor@gmail•com>,
"linuxppc-dev list" <linuxppc-dev@ozlabs•org>
Subject: Re: snd-aoa status update / automatic driver loading
Date: Sat, 20 May 2006 00:40:27 +1000 [thread overview]
Message-ID: <87zmhef57o.fsf@briny.internal.ondioline.org> (raw)
In-Reply-To: 1148046418.3864.14.camel@johannes.berg
Johannes Berg <johannes@sipsolutions•net> writes:
> On Fri, 2006-05-19 at 23:20 +1000, Paul Collins wrote:
>
>> I have a PowerBook5,4 here and I'd be happy to test support for it.
>> The hardware is identified by snd-powermac as "PowerMac Snapper" and
>> the layout ID appears to be "3".
>
> Try downloading snd-aoa and in snd-aoa-fabric-layout.c change the two
> occurrences of '70' to '3'. If it works, let me know and I'll add the
> proper entry for it.
When I probed i2sbus nothing much seemed to happen, so I added a
printk to see what layout ID was being returned, and I'm getting 51,
not 3 as found in the device tree. However, when I use 51 instead of
3 in those two places, I still don't get much happening.
Here's the dmesg after "modprobe i2sbus":
May 20 00:35:51 briny kernel: i2sbus: mapped i2s control registers
May 20 00:35:51 briny kernel: i2sbus: control register contents:
May 20 00:35:51 briny kernel: i2sbus: fcr0 = 0x0
May 20 00:35:51 briny kernel: i2sbus: cell_control = 0x0
May 20 00:35:51 briny kernel: i2sbus: fcr2 = 0x4ef1c25
May 20 00:35:51 briny kernel: i2sbus: fcr3 = 0x0
May 20 00:35:51 briny kernel: i2sbus: clock_control = 0x0
May 20 00:35:51 briny kernel: layout id is 51
May 20 00:35:51 briny kernel: i2sbus control destroyed
And lsmod:
Module Size Used by
i2sbus 21632 0
soundbus 8132 1 i2sbus
radeon 129896 0
drm 82968 1 radeon
snd_usb_audio 90624 0
snd_usb_lib 19232 1 snd_usb_audio
snd_rawmidi 29280 1 snd_usb_lib
snd_hwdep 11012 1 snd_usb_audio
hci_usb 14164 3
snd_pcm_oss 50816 0
snd_pcm 103588 3 i2sbus,snd_usb_audio,snd_pcm_oss
snd_timer 27140 1 snd_pcm
snd_page_alloc 11432 1 snd_pcm
pcmcia 45776 0
ehci_hcd 37224 0
bcm43xx 448916 0
ieee80211softmac 32384 1 bcm43xx
uninorth_agp 11112 1
agpgart 38484 2 drm,uninorth_agp
ohci_hcd 24452 0
ieee80211 36776 2 bcm43xx,ieee80211softmac
ieee80211_crypt 6880 1 ieee80211
yenta_socket 30412 1
rsrc_nonstatic 13472 1 yenta_socket
pcmcia_core 49592 3 pcmcia,yenta_socket,rsrc_nonstatic
Here are the changes I made.
diff --git a/aoa/fabrics/snd-aoa-fabric-layout.c b/aoa/fabrics/snd-aoa-fabric-layout.c
index 65cda87..180dca4 100644
--- a/aoa/fabrics/snd-aoa-fabric-layout.c
+++ b/aoa/fabrics/snd-aoa-fabric-layout.c
@@ -84,7 +84,7 @@ MODULE_ALIAS("sound-layout-64");
MODULE_ALIAS("sound-layout-65");
MODULE_ALIAS("sound-layout-68");
MODULE_ALIAS("sound-layout-69");
-MODULE_ALIAS("sound-layout-70");
+MODULE_ALIAS("sound-layout-51");
MODULE_ALIAS("sound-layout-72");
MODULE_ALIAS("sound-layout-86");
MODULE_ALIAS("sound-layout-84");
@@ -214,7 +214,7 @@ static struct layout layouts[] = {
},
.busname = "digital in", .pcmid = 1 },
/* Early 2005 PowerBook */
- { .layout_id = 70,
+ { .layout_id = 51,
.codecs[0] = {
.name = "tas",
.connections = tas_connections_nolineout,
diff --git a/soundbus/i2sbus/i2sbus-core.c b/soundbus/i2sbus/i2sbus-core.c
index f6463cb..ff5b52e 100644
--- a/soundbus/i2sbus/i2sbus-core.c
+++ b/soundbus/i2sbus/i2sbus-core.c
@@ -130,7 +130,10 @@ static int i2sbus_add_dev(struct macio_d
u32 *layout_id;
layout_id = (u32*) get_property(sound, "layout-id", NULL);
if (layout_id) {
+ printk(KERN_INFO "layout id is %d\n", *layout_id);
snprintf(dev->sound.modalias, 32, "sound-layout-%d", *layout_id);
+ } else {
+ printk(KERN_INFO "no layout id!?\n");
}
}
--
Dag vijandelijk luchtschip de huismeester is dood
next prev parent reply other threads:[~2006-05-19 14:43 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-17 10:09 snd-aoa status update / automatic driver loading Johannes Berg
2006-05-17 18:57 ` Tony Vroon
2006-05-19 10:22 ` Johannes Berg
2006-05-20 23:56 ` Benjamin Herrenschmidt
2006-05-22 6:42 ` Johannes Berg
2006-05-23 22:15 ` Benjamin Herrenschmidt
2006-05-24 9:42 ` Johannes Berg
2006-05-25 8:00 ` Benjamin Herrenschmidt
2006-05-25 9:42 ` Johannes Berg
2006-05-26 1:30 ` Benjamin Herrenschmidt
2006-05-17 19:53 ` Andreas Schwab
2006-05-18 10:14 ` Johannes Berg
2006-05-17 21:54 ` Wolfgang Pfeiffer
2006-05-17 22:19 ` Wolfgang Pfeiffer
2006-05-18 10:13 ` Johannes Berg
2006-05-18 18:17 ` Wolfgang Pfeiffer
2006-05-18 22:06 ` Andreas Schwab
2006-05-19 12:50 ` Johannes Berg
2006-05-19 14:40 ` Wolfgang Pfeiffer
2006-05-19 14:40 ` Johannes Berg
2006-05-17 22:30 ` Dean Hamstead
2006-05-18 0:28 ` Wolfgang Pfeiffer
2006-05-18 0:39 ` Dean Hamstead
2006-05-18 1:01 ` Wolfgang Pfeiffer
2006-05-18 1:08 ` Benjamin Herrenschmidt
2006-05-18 7:25 ` Eddy Petrişor
2006-05-18 10:23 ` Johannes Berg
2006-05-19 13:20 ` Paul Collins
2006-05-19 13:46 ` Johannes Berg
2006-05-19 14:40 ` Paul Collins [this message]
2006-05-19 14:49 ` Johannes Berg
2006-05-19 15:13 ` Paul Collins
2006-05-19 14:33 ` Andreas Schwab
2006-05-19 14:37 ` Johannes Berg
2006-05-23 15:41 ` Sjoerd Simons
2006-05-25 7:21 ` Eddy Petrişor
2006-05-25 7:21 ` Eddy Petrişor
2006-05-25 9:43 ` Johannes Berg
2006-05-25 17:44 ` Eddy Petrişor
2006-05-25 18:47 ` Johannes Berg
2006-05-18 8:56 ` Rene Rebe
2006-05-18 10:08 ` Johannes Berg
[not found] ` <200605180002.01669.borge@arivene.net>
[not found] ` <20060518004141.GC1552@kunpuu.plessy.org>
2006-05-20 14:57 ` Benjamin Berg
2006-05-20 23:59 ` Benjamin Herrenschmidt
2006-05-23 3:11 ` Hollis Blanchard
2006-05-23 12:27 ` Johannes Berg
2006-05-23 14:46 ` Hollis Blanchard
2006-05-23 15:25 ` Hollis Blanchard
2006-05-24 9:41 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zmhef57o.fsf@briny.internal.ondioline.org \
--to=paul@briny$(echo .)ondioline.org \
--cc=debian-powerpc@lists$(echo .)debian.org \
--cc=eddy.petrisor@gmail$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox