From: David Laight <David.Laight@ACULAB•COM>
To: 'Christoph Hellwig' <hch@infradead•org>, Arnd Bergmann <arnd@kernel•org>
Cc: "mark.rutland@arm•com" <mark.rutland@arm•com>,
"dalias@libc•org" <dalias@libc•org>,
"linux-ia64@vger•kernel.org" <linux-ia64@vger•kernel.org>,
"linux-sh@vger•kernel.org" <linux-sh@vger•kernel.org>,
"peterz@infradead•org" <peterz@infradead•org>,
"linux-mips@vger•kernel.org" <linux-mips@vger•kernel.org>,
"jcmvbkbc@gmail•com" <jcmvbkbc@gmail•com>,
"guoren@kernel•org" <guoren@kernel•org>,
"sparclinux@vger•kernel.org" <sparclinux@vger•kernel.org>,
"linux-riscv@lists•infradead.org"
<linux-riscv@lists•infradead.org>,
"will@kernel•org" <will@kernel•org>,
"ardb@kernel•org" <ardb@kernel•org>,
"linux-arch@vger•kernel.org" <linux-arch@vger•kernel.org>,
"linux-s390@vger•kernel.org" <linux-s390@vger•kernel.org>,
"bcain@codeaurora•org" <bcain@codeaurora•org>,
"linux-hexagon@vger•kernel.org" <linux-hexagon@vger•kernel.org>,
"deller@gmx•de" <deller@gmx•de>,
"x86@kernel•org" <x86@kernel•org>,
"linux@armlinux•org.uk" <linux@armlinux•org.uk>,
"linux-csky@vger•kernel.org" <linux-csky@vger•kernel.org>,
Christoph Hellwig <hch@lst•de>,
"mingo@redhat•com" <mingo@redhat•com>,
"geert@linux-m68k•org" <geert@linux-m68k•org>,
"linux-snps-arc@lists•infradead.org"
<linux-snps-arc@lists•infradead.org>,
"linux-xtensa@linux-xtensa•org" <linux-xtensa@linux-xtensa•org>,
"arnd@arndb•de" <arnd@arndb•de>,
"hca@linux•ibm.com" <hca@linux•ibm.com>,
"linux-um@lists•infradead.org" <linux-um@lists•infradead.org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"richard@nod•at" <richard@nod•at>,
"linux-m68k@lists•linux-m68k.org"
<linux-m68k@lists•linux-m68k.org>,
"openrisc@lists•librecores.org" <openrisc@lists•librecores.org>,
"green.hu@gmail•com" <green.hu@gmail•com>,
"shorne@gmail•com" <shorne@gmail•com>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"monstr@monstr•eu" <monstr@monstr•eu>,
"tsbogend@alpha•franken.de" <tsbogend@alpha•franken.de>,
"nickhu@andestech•com" <nickhu@andestech•com>,
"linux-parisc@vger•kernel.org" <linux-parisc@vger•kernel.org>,
"linux-mm@kvack•org" <linux-mm@kvack•org>,
"linux-api@vger•kernel.org" <linux-api@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"stable@vger•kernel.org" <stable@vger•kernel.org>,
"dinguyen@kernel•org" <dinguyen@kernel•org>,
"ebiederm@xmission•com" <ebiederm@xmission•com>,
"linux-alpha@vger•kernel.org" <linux-alpha@vger•kernel.org>,
"akpm@linux-foundation•org" <akpm@linux-foundation•org>,
Linus Torvalds <torvalds@linux-foundation•org>,
"davem@davemloft•net" <davem@davemloft•net>
Subject: RE: [PATCH 03/14] nds32: fix access_ok() checks in get/put_user
Date: Mon, 14 Feb 2022 17:10:05 +0000 [thread overview]
Message-ID: <8a6e309687d647e3aef8a88bdb0922af@AcuMS.aculab.com> (raw)
In-Reply-To: <YgqK1ihlJvRFHJ9h@infradead.org>
From: Christoph Hellwig
> Sent: 14 February 2022 17:01
>
> On Mon, Feb 14, 2022 at 05:34:41PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb•de>
> >
> > The get_user()/put_user() functions are meant to check for
> > access_ok(), while the __get_user()/__put_user() functions
> > don't.
> >
> > This broke in 4.19 for nds32, when it gained an extraneous
> > check in __get_user(), but lost the check it needs in
> > __put_user().
>
> Can we follow the lead of MIPS (which this was originally copied
> from I think) and kill the pointless __get/put_user_check wrapper
> that just obsfucate the code?
Is it possible to make all these architectures fall back to
a common definition somewhere?
Maybe they need to define ACCESS_OK_USER_LIMIT - which can be
different from TASK_SIZE.
There'll be a few special cases, but most architectures have
kernel addresses above userspace ones.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-02-14 17:10 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 16:34 [PATCH 00/14] clean up asm/uaccess.h, kill set_fs for good Arnd Bergmann
2022-02-14 16:34 ` [PATCH 01/14] uaccess: fix integer overflow on access_ok() Arnd Bergmann
2022-02-14 16:58 ` Christoph Hellwig
2022-02-14 16:34 ` [PATCH 02/14] sparc64: add __{get,put}_kernel_nocheck() Arnd Bergmann
2022-02-14 16:34 ` [PATCH 03/14] nds32: fix access_ok() checks in get/put_user Arnd Bergmann
2022-02-14 17:01 ` Christoph Hellwig
2022-02-14 17:10 ` David Laight [this message]
2022-02-15 9:18 ` Arnd Bergmann
2022-02-15 10:25 ` Greg KH
2022-02-14 16:34 ` [PATCH 04/14] x86: use more conventional access_ok() definition Arnd Bergmann
2022-02-14 17:02 ` Christoph Hellwig
2022-02-14 19:45 ` Arnd Bergmann
2022-02-14 20:00 ` Christoph Hellwig
2022-02-14 20:01 ` Linus Torvalds
2022-02-14 20:17 ` Al Viro
2022-02-15 2:47 ` Al Viro
2022-02-14 20:24 ` Linus Torvalds
2022-02-14 22:13 ` David Laight
2022-02-14 16:34 ` [PATCH 05/14] uaccess: add generic __{get,put}_kernel_nofault Arnd Bergmann
2022-02-14 17:02 ` Christoph Hellwig
2022-02-15 0:31 ` Al Viro
2022-02-15 13:16 ` Arnd Bergmann
2022-02-14 16:34 ` [PATCH 06/14] mips: use simpler access_ok() Arnd Bergmann
2022-02-14 16:34 ` [PATCH 07/14] uaccess: generalize access_ok() Arnd Bergmann
2022-02-14 17:04 ` Christoph Hellwig
2022-02-14 17:15 ` Al Viro
2022-02-14 19:25 ` Arnd Bergmann
2022-02-15 10:58 ` Mark Rutland
2022-02-14 16:34 ` [PATCH 08/14] arm64: simplify access_ok() Arnd Bergmann
2022-02-14 21:06 ` Robin Murphy
2022-02-15 8:17 ` Ard Biesheuvel
2022-02-15 9:12 ` Arnd Bergmann
2022-02-15 9:21 ` Ard Biesheuvel
2022-02-15 9:39 ` Arnd Bergmann
2022-02-15 10:39 ` Mark Rutland
2022-02-15 10:37 ` Mark Rutland
2022-02-16 19:43 ` Christophe Leroy
2022-02-15 9:30 ` David Laight
2022-02-15 11:24 ` Mark Rutland
2022-02-15 11:07 ` Mark Rutland
2022-02-14 16:34 ` [PATCH 09/14] m68k: drop custom __access_ok() Arnd Bergmann
2022-02-15 0:37 ` Al Viro
2022-02-15 6:29 ` Christoph Hellwig
2022-02-15 7:13 ` Al Viro
2022-02-15 10:02 ` Arnd Bergmann
2022-02-15 13:28 ` David Laight
2022-02-14 16:34 ` [PATCH 10/14] uaccess: remove most CONFIG_SET_FS users Arnd Bergmann
2022-02-14 17:06 ` Christoph Hellwig
2022-02-14 19:40 ` Arnd Bergmann
2022-02-14 16:34 ` [PATCH 11/14] sparc64: remove CONFIG_SET_FS support Arnd Bergmann
2022-02-14 17:06 ` Christoph Hellwig
2022-02-16 13:06 ` Arnd Bergmann
2022-02-15 0:48 ` Al Viro
2022-02-16 13:07 ` Arnd Bergmann
2022-02-14 16:34 ` [PATCH 12/14] sh: " Arnd Bergmann
2022-02-14 16:34 ` [PATCH 13/14] ia64: " Arnd Bergmann
2022-02-14 16:34 ` [PATCH 14/14] uaccess: drop set_fs leftovers Arnd Bergmann
2022-02-15 3:03 ` Al Viro
2022-02-15 7:46 ` Helge Deller
2022-02-15 8:10 ` Arnd Bergmann
2022-02-14 17:35 ` [PATCH 00/14] clean up asm/uaccess.h, kill set_fs for good Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a6e309687d647e3aef8a88bdb0922af@AcuMS.aculab.com \
--to=david.laight@aculab$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=ardb@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=arnd@kernel$(echo .)org \
--cc=bcain@codeaurora$(echo .)org \
--cc=dalias@libc$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=dinguyen@kernel$(echo .)org \
--cc=ebiederm@xmission$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=green.hu@gmail$(echo .)com \
--cc=guoren@kernel$(echo .)org \
--cc=hca@linux$(echo .)ibm.com \
--cc=hch@infradead$(echo .)org \
--cc=hch@lst$(echo .)de \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-csky@vger$(echo .)kernel.org \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-um@lists$(echo .)infradead.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=nickhu@andestech$(echo .)com \
--cc=openrisc@lists$(echo .)librecores.org \
--cc=peterz@infradead$(echo .)org \
--cc=richard@nod$(echo .)at \
--cc=shorne@gmail$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox