Date: Fri, 18 Apr 2008 01:38:57 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>, <linuxppc-dev@ozlabs.org>,
	<linux-kernel@vger.kernel.org>, Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id
Message-ID: <20080418013857.92824cfb.akpm@linux-foundation.org>
In-Reply-To: <1208506747.6958.402.camel@pasglop>
References: <20080418065728.31AF4DE255@ozlabs.org>
	<20080418000717.5a9c9758.akpm@linux-foundation.org>
	<1208506747.6958.402.camel@pasglop>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Sender: <linux-kernel-owner@vger.kernel.org>
Precedence: bulk
X-MS-Exchange-Organization-OriginalArrivalTime: 18 Apr 2008 08:40:56.9375
 (UTC)
X-MS-Exchange-Organization-PRD: vger.kernel.org
Received-SPF: None (mcl-sms-ns1.digi.com: linux-kernel-owner@vger.kernel.org
 does not designate permitted sender hosts)
X-MS-Exchange-Organization-PCL: 2
X-MS-Exchange-Organization-Antispam-Report: DV:3.3.6407.600;SID:SenderIDStatus None;OrigIP:216.82.253.131
X-MS-Exchange-Organization-OriginalSize: 4353
X-MS-Exchange-Organization-SCL: 0
X-MS-Exchange-Organization-SenderIdResult: NONE
X-MS-Exchange-Organization-AuthSource: mcl-sms-ns1.digi.com
X-MS-Exchange-Organization-AuthAs: Anonymous

On Fri, 18 Apr 2008 18:19:07 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> 
> On Fri, 2008-04-18 at 00:07 -0700, Andrew Morton wrote:
> > On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > 
> > > Use the __weak macro instead of the longer __attribute__ ((weak)) form
> > > 
> > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > --
> > > 
> > >  init/main.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > --- linux-work.orig/init/main.c	2008-04-18 16:44:32.000000000 +1000
> > > +++ linux-work/init/main.c	2008-04-18 16:44:37.000000000 +1000
> > > @@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
> > >  	cpu_set(cpu, cpu_possible_map);
> > >  }
> > >  
> > > -void __init __attribute__((weak)) smp_setup_processor_id(void)
> > > +void __init __weak smp_setup_processor_id(void)
> > >  {
> > >  }
> > 
> > ack on all three. Please fold #3 into #1 and add both to git-powerpc.
> 
> Damn ! I took 5mn to actually split it out in order to not do two
> different things in one patch :-)

ah, I misread it.  I thought this was changing the __attribute__((weak))
which patch #1 added.  But it's changing a different one.  I though that
was odd.

> Will do.

whatever ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/