Subject: Re: [PATCH 1/3] Bamboo DTS

From: Segher Boessenkool <[email-masked]>
Date: Mon, 14 May 2007 17:21:26 +0200

> +			i-cache-size = <2000000>;
> +			d-cache-size = <2000000>;

32MB yeah right :-)

> +		MAL0: mcmal {

> +			#address-cells = <0>;
> +			#size-cells = <0>;
> +			interrupt-map-mask = <ffffffff>;

These three properties aren't needed (map-mask defaults
to all bits, #size is never used, #address defaults to 0
for interrupt mapping and isn't used in any other context).

> +		  	ranges = <00000000 0 00000000 80000000
> +			          80000000 0 80000000 80000000>;

You can avoid having two ranges by using #size-cells = 2
in the root node.  Having two ranges is a problem if any
mapping straddles the boundary between the two.

Segher