Subject: Re: [PATCH v7 1/8] sched/fair: Get rid of sched_domains_curr_level hack for tl->cpumask()

From: Tim Chen <[email-masked]>
Date: Thu, 28 Aug 2025 16:06:37 -0700

On Tue, 2025-08-26 at 04:13 +0000, K Prateek Nayak wrote:
> From: Peter Zijlstra <[email-masked]>
> 
> 
...snip...

>  
> -static const struct cpumask *cpu_mc_mask(int cpu)
> +static const struct cpumask *cpu_mc_mask(struct sched_domain_topology_level *tl, int cpu)
>  {
>  	return cpu_coregroup_mask(cpu);
>  }
>  
> +static const struct cpumask *cpu_pkg_mask(struct sched_domain_topology_level *tl, int cpu)
> +{
> +	return cpu_node_mask(cpu);
> +}
> +

I suggest that we rename this function as tl_node_mask as we are
returning the node mask.  We could have multiple nodes in a package
for SNC and it may not actually be pkg_mask for such case.

Rest of the patch looks good.

Thanks.

Tim