From: Jan Stancek <jstancek@redhat•com>
To: Raghavendra K T <raghavendra.kt@linux•vnet.ibm.com>
Cc: mingo@redhat•com, peterz@infradead•org, benh@kernel•crashing.org,
paulus@samba•org, mpe@ellerman•id.au, anton@samba•org,
akpm@linux-foundation•org, gkurz@linux•vnet.ibm.com,
grant likely <grant.likely@linaro•org>,
nikunj@linux•vnet.ibm.com, vdavydov@parallels•com,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
linux-mm@kvack•org
Subject: Re: [PATCH] Fix: PowerNV crash with 4.4.0-rc8 at sched_init_numa
Date: Mon, 18 Jan 2016 06:06:22 -0500 (EST) [thread overview]
Message-ID: <969916137.9009700.1453115182823.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1452884483-11676-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com>
----- Original Message -----
> From: "Raghavendra K T" <raghavendra.kt@linux•vnet.ibm.com>
> To: mingo@redhat•com, peterz@infradead•org, benh@kernel•crashing.org, paulus@samba•org, mpe@ellerman•id.au,
> anton@samba•org, akpm@linux-foundation•org
> Cc: jstancek@redhat•com, gkurz@linux•vnet.ibm.com, "grant likely" <grant.likely@linaro•org>,
> nikunj@linux•vnet.ibm.com, vdavydov@parallels•com, "raghavendra kt" <raghavendra.kt@linux•vnet.ibm.com>,
> linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org, linux-mm@kvack•org
> Sent: Friday, 15 January, 2016 8:01:23 PM
> Subject: [PATCH] Fix: PowerNV crash with 4.4.0-rc8 at sched_init_numa
>
> Commit c118baf80256 ("arch/powerpc/mm/numa.c: do not allocate bootmem
> memory for non existing nodes") avoided bootmem memory allocation for
> non existent nodes.
>
> When DEBUG_PER_CPU_MAPS enabled, powerNV system failed to boot because
> in sched_init_numa, cpumask_or operation was done on unallocated nodes.
> Fix that by making cpumask_or operation only on existing nodes.
>
> [ Tested with and w/o DEBUG_PER_CPU_MAPS on x86 and powerpc ]
>
> Reported-by: Jan Stancek <jstancek@redhat•com>
Tested-by: Jan Stancek <jstancek@redhat•com>
I also verified with my setup, that this made the crash go away.
Report mail thread for reference:
https://lists.ozlabs.org/pipermail/linuxppc-dev/2016-January/137691.html
Regards,
Jan
> Signed-off-by: Raghavendra K T <raghavendra.kt@linux•vnet.ibm.com>
> ---
> kernel/sched/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 44253ad..474658b 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6840,7 +6840,7 @@ static void sched_init_numa(void)
>
> sched_domains_numa_masks[i][j] = mask;
>
> - for (k = 0; k < nr_node_ids; k++) {
> + for_each_node(k) {
> if (node_distance(j, k) > sched_domains_numa_distance[i])
> continue;
>
> --
> 1.7.11.7
>
>
next prev parent reply other threads:[~2016-01-18 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 19:01 [PATCH] Fix: PowerNV crash with 4.4.0-rc8 at sched_init_numa Raghavendra K T
2016-01-18 11:06 ` Jan Stancek [this message]
2016-01-19 13:38 ` [tip:sched/urgent] sched: Fix crash in sched_init_numa() tip-bot for Raghavendra K T
2016-02-08 11:38 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=969916137.9009700.1453115182823.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anton@samba$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=gkurz@linux$(echo .)vnet.ibm.com \
--cc=grant.likely@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=nikunj@linux$(echo .)vnet.ibm.com \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=raghavendra.kt@linux$(echo .)vnet.ibm.com \
--cc=vdavydov@parallels$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox