From: Alex Dubov <oakad@yahoo•com>
To: Anton Vorontsov <cbouatmailru@gmail•com>
Cc: linuxppc-dev@lists•ozlabs.org, davem@davemloft•net, mlcreech@gmail•com
Subject: Re: [PATCH] gianfar: Fall back to software tcp/udp checksum on older controllers
Date: Thu, 27 Jan 2011 18:43:44 -0800 (PST) [thread overview]
Message-ID: <983577.58398.qm@web37603.mail.mud.yahoo.com> (raw)
In-Reply-To: <20110127095100.GA5411@oksana.dev.rtsoft.ru>
> > -=A0=A0=A0 =A0=A0=A0=0A> gfar_tx_checksum(skb, fcb);=0A> > +=A0=A0=A0 =
=A0=A0=A0 switch=0A> (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12))=0A> >=
+=A0=A0=A0 =A0=A0=A0=0A> =A0=A0=A0 ? 1 : 0) {=0A> =0A> The switch construc=
tion is quite bizarre. ;-) Why not=0A> =0A=0AMy testing shows that even on =
broken chips unaligned packets are quite rare=0A(only some SYN packets seem=
to be affected). So I tried to leave the=0Achecksum offload path as the mo=
st preferred one.=0A=0A=0A=0A
next prev parent reply other threads:[~2011-01-28 2:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 8:14 [PATCH] gianfar: Fall back to software tcp/udp checksum on older controllers Alex Dubov
2011-01-27 9:51 ` Anton Vorontsov
2011-01-27 22:23 ` David Miller
2011-01-28 2:43 ` Alex Dubov [this message]
2011-01-28 4:37 ` [PATCH v2] " Alex Dubov
2011-01-28 9:10 ` [PATCH v2] gianfar: Fall back to software tcp/udp checksum on oldercontrollers David Laight
2011-01-28 16:56 ` Scott Wood
2011-01-28 19:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=983577.58398.qm@web37603.mail.mud.yahoo.com \
--to=oakad@yahoo$(echo .)com \
--cc=cbouatmailru@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mlcreech@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox