Subject: Re: [PATCH] gianfar: Fall back to software tcp/udp checksum on older controllers

From: Alex Dubov <[email-masked]>
Date: Thu, 27 Jan 2011 18:43:44 -0800 (PST)

> > -       
> gfar_tx_checksum(skb, fcb);
> > +        switch
> (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12))
> > +       
>     ? 1 : 0) {
> 
> The switch construction is quite bizarre. ;-) Why not
> 

My testing shows that even on broken chips unaligned packets are quite rare
(only some SYN packets seem to be affected). So I tried to leave the
checksum offload path as the most preferred one.