From: Kumar Gala <galak@kernel•crashing.org>
To: Anton Vorontsov <avorontsov@ru•mvista.com>
Cc: Scott Wood <scottwood@freescale•com>,
linuxppc-dev@ozlabs•org, Li Yang <leoli@freescale•com>
Subject: Re: [PATCH v2 2/2] powerpc/83xx: Move gianfar mdio nodes under the ethernet nodes
Date: Wed, 18 Mar 2009 08:21:18 -0500 [thread overview]
Message-ID: <D688018D-6CE0-4627-B813-FC552B1A6E83@kernel.crashing.org> (raw)
In-Reply-To: <20090317185902.GB4055@oksana.dev.rtsoft.ru>
On Mar 17, 2009, at 1:59 PM, Anton Vorontsov wrote:
> Currently it doesn't matter where the mdio nodes are placed, but with
> power management support (i.e. when sleep = <> properties will take
> effect), mdio nodes placement will become important: mdio controller
> is a part of the ethernet block, so the mdio nodes should be placed
> correctly. Otherwise we may wrongly assume that MDIO controllers are
> available during sleep.
>
> Suggested-by: Scott Wood <scottwood@freescale•com>
> Signed-off-by: Anton Vorontsov <avorontsov@ru•mvista.com>
> ---
>
> Changes since RFC:
> - Don't use compatible = "simple-bus" for gianfar nodes.
>
> arch/powerpc/boot/dts/mpc8315erdb.dts | 80 +++++++++++++++
> +-------------
> arch/powerpc/boot/dts/mpc8349emitx.dts | 69 ++++++++++++
> +-----------
> arch/powerpc/boot/dts/mpc8349emitxgp.dts | 42 ++++++++-------
> arch/powerpc/boot/dts/mpc834x_mds.dts | 81 +++++++++++++++
> +-------------
> arch/powerpc/boot/dts/mpc8377_mds.dts | 80 +++++++++++++++
> +-------------
> arch/powerpc/boot/dts/mpc8377_rdb.dts | 67 ++++++++++++
> +-----------
> arch/powerpc/boot/dts/mpc8378_mds.dts | 80 +++++++++++++++
> +-------------
> arch/powerpc/boot/dts/mpc8378_rdb.dts | 69 +++++++++++++
> +-----------
> arch/powerpc/boot/dts/mpc8379_mds.dts | 79 +++++++++++++++
> +------------
> arch/powerpc/boot/dts/mpc8379_rdb.dts | 66 ++++++++++++
> +----------
> arch/powerpc/platforms/83xx/mpc834x_itx.c | 1 +
> arch/powerpc/platforms/83xx/mpc834x_mds.c | 1 +
> arch/powerpc/platforms/83xx/mpc837x_mds.c | 1 +
> arch/powerpc/platforms/83xx/mpc837x_rdb.c | 1 +
> 14 files changed, 398 insertions(+), 319 deletions(-)
If we do this we should also fixup all the 85xx & 86xx .dts
> diff --git a/arch/powerpc/boot/dts/mpc8315erdb.dts b/arch/powerpc/
> boot/dts/mpc8315erdb.dts
> index 88d691c..c0d5b34 100644
> --- a/arch/powerpc/boot/dts/mpc8315erdb.dts
> +++ b/arch/powerpc/boot/dts/mpc8315erdb.dts
> @@ -190,66 +190,74 @@
> phy_type = "utmi";
> };
[snip]
>
> enet0: ethernet@24000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> cell-index = <0>;
> device_type = "network";
> model = "eTSEC";
> compatible = "gianfar";
> reg = <0x24000 0x1000>;
> + ranges;
Can this be proper?
ranges = <0x0 0x24520 0x20>;
>
> local-mac-address = [ 00 00 00 00 00 00 ];
> interrupts = <32 0x8 33 0x8 34 0x8>;
> interrupt-parent = <&ipic>;
> tbi-handle = <&tbi0>;
> phy-handle = < &phy0 >;
> +
> + mdio@24520 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "fsl,gianfar-mdio";
> + reg = <0x24520 0x20>;
update here for ranges change.
>
> +
> + phy0: ethernet-phy@0 {
> + interrupt-parent = <&ipic>;
> + interrupts = <20 0x8>;
> + reg = <0x0>;
> + device_type = "ethernet-phy";
> + };
> +
> + phy1: ethernet-phy@1 {
> + interrupt-parent = <&ipic>;
> + interrupts = <19 0x8>;
> + reg = <0x1>;
> + device_type = "ethernet-phy";
> + };
> +
> + tbi0: tbi-phy@11 {
> + reg = <0x11>;
> + device_type = "tbi-phy";
> + };
> + };
> };
- k
next prev parent reply other threads:[~2009-03-18 13:21 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 18:59 [PATCH v2 2/2] powerpc/83xx: Move gianfar mdio nodes under the ethernet nodes Anton Vorontsov
2009-03-18 13:21 ` Kumar Gala [this message]
2009-03-18 15:28 ` Anton Vorontsov
2009-03-18 15:43 ` Scott Wood
2009-03-18 15:50 ` Grant Likely
2009-03-19 1:20 ` David Gibson
2009-03-18 19:59 ` Anton Vorontsov
2009-03-18 20:00 ` [PATCH v3 1/4] powerpc/83xx: Add power management support for MPC837x boards Anton Vorontsov
2009-03-18 20:00 ` [PATCH v3 2/4] powerpc/83xx: Move gianfar mdio nodes under the ethernet nodes Anton Vorontsov
2009-03-18 20:00 ` [PATCH v3 3/4] powerpc/85xx: " Anton Vorontsov
2009-03-18 20:05 ` Scott Wood
2009-03-18 20:23 ` Anton Vorontsov
2009-03-18 20:27 ` Scott Wood
2009-03-18 20:29 ` Anton Vorontsov
2009-03-18 20:31 ` Scott Wood
2009-03-18 20:33 ` Anton Vorontsov
2009-03-18 20:35 ` Scott Wood
2009-03-18 20:39 ` Anton Vorontsov
2009-03-18 20:46 ` Scott Wood
2009-03-18 21:00 ` Anton Vorontsov
2009-03-18 20:00 ` [PATCH v3 4/4] powerpc/86xx: " Anton Vorontsov
2009-04-08 9:18 ` [PATCH 6/6] powerpc/fsl_soc: Isolate legacy fsl_spi support to mpc832x_rdb boards Peter Korsgaard
2009-04-17 5:13 ` Peter Korsgaard
2009-04-17 12:23 ` Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2008-12-05 20:09 [PATCH 0/7] OpenFirmware support for the spi_mpc83xx driver Anton Vorontsov
2008-12-05 20:10 ` [PATCH 1/7] powerpc: Implement get_brgfreq() and get_baudrate() stubs Anton Vorontsov
2008-12-16 18:24 ` Kumar Gala
2008-12-05 20:10 ` [PATCH 2/7] spi_mpc83xx: Fix sparse warnings Anton Vorontsov
2008-12-05 20:10 ` [PATCH 3/7] spi_mpc83xx: Rework chip selects handling Anton Vorontsov
2008-12-05 20:10 ` [PATCH 4/7] spi_mpc83xx: Add OF platform driver bindings Anton Vorontsov
2008-12-05 20:10 ` [PATCH 5/7] powerpc/fsl_soc: Isolate legacy fsl_spi support to mpc832x_rdb boards Anton Vorontsov
2008-12-05 20:10 ` [PATCH 6/7] powerpc: Add mmc-spi-slot bindings Anton Vorontsov
2008-12-05 20:10 ` [PATCH 7/7] powerpc/83xx: Add mmc-spi support via the device tree for MPC8323E-RDB Anton Vorontsov
2008-12-18 18:33 ` [PATCH 0/7] OpenFirmware support for the spi_mpc83xx driver Anton Vorontsov
2009-01-07 4:28 ` Kumar Gala
2009-01-23 19:49 ` [PATCH resend 0/6] " Anton Vorontsov
2009-01-23 19:50 ` [PATCH 1/6] spi_mpc83xx: Fix sparse warnings Anton Vorontsov
2009-01-23 19:50 ` [PATCH 2/6] spi_mpc83xx: Rework chip selects handling Anton Vorontsov
2009-01-23 19:50 ` [PATCH 3/6] spi_mpc83xx: Add OF platform driver bindings Anton Vorontsov
2009-01-23 19:50 ` [PATCH 4/6] powerpc: Add mmc-spi-slot bindings Anton Vorontsov
2009-01-23 19:50 ` [PATCH 5/6] powerpc/83xx: Add mmc-spi support via the device tree for MPC8323E-RDB Anton Vorontsov
2009-01-23 19:50 ` [PATCH 6/6] powerpc/fsl_soc: Isolate legacy fsl_spi support to mpc832x_rdb boards Anton Vorontsov
2009-03-09 16:53 ` [PATCH resend 0/6] OpenFirmware support for the spi_mpc83xx driver Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D688018D-6CE0-4627-B813-FC552B1A6E83@kernel.crashing.org \
--to=galak@kernel$(echo .)crashing.org \
--cc=avorontsov@ru$(echo .)mvista.com \
--cc=leoli@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox