From: Kumar Gala <galak@kernel•crashing.org>
To: Segher Boessenkool <segher@kernel•crashing.org>
Cc: Paul Mackerras <paulus@samba•org>,
linuxppc-dev list <linuxppc-dev@ozlabs•org>
Subject: Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node
Date: Tue, 10 Jul 2007 21:02:41 -0500 [thread overview]
Message-ID: <DB462F87-151E-4F21-80CF-209326FCEB67@kernel.crashing.org> (raw)
In-Reply-To: <963D5B48-F1E5-4930-9F29-98D7F0E33C0A@kernel.crashing.org>
On Jul 10, 2007, at 3:25 PM, Segher Boessenkool wrote:
>> pci1: pci@8000 {
>> interrupt-map-mask = <1f800 0 0 7>;
>
> Set the mask to <1800 0 0 7>, and you need only 16
> entries to encode the swizzle. Except...
>
>> + /* bus 1 , idsel 0x2 Tsi310 bridge secondary */
>
> ...interrupts on bus 1 should be swizzled on bus 1, not
> at the PHB. Really. It is a horrible workaround for a
> non-existing problem to do it here, and I promise you
> it _will_ come back to hurt you later. Not a threat,
> just a promise :-)
>
>> - compatible = "85xx";
>> + compatible = "fsl,mpc85xx-pci","85xx";
>
> No more "xx" please...
>
>> + pci@a000 {
>> + interrupt-map-mask = <f800 0 0 7>;
>> + interrupt-map = <
>> +
>> + /* IDSEL 0x0 (PEX) */
>> + 00000 0 0 1 &mpic 0 1
>> + 00000 0 0 2 &mpic 1 0
>> + 00000 0 0 3 &mpic 2 0
>> + 00000 0 0 4 &mpic 3 0>;
>
> Why sense 0 for all but the first entry in this map?
>
>> + compatible = "fsl,mpc86xx-pciex","86xx";
>
> And "xx" again. Aren't the 85- and 86- PCIe controllers
> compatible, btw?
They are, but we need to distinguish between 83xx, 85xx, and 86xx
pci, pciex, pci-x controllers.
- k
next prev parent reply other threads:[~2007-07-11 2:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 15:52 [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node Zang Roy-r61911
2007-07-10 20:25 ` Segher Boessenkool
2007-07-11 2:02 ` Kumar Gala [this message]
2007-07-11 10:57 ` Segher Boessenkool
2007-07-11 2:44 ` Zang Roy-r61911
2007-07-11 10:59 ` Segher Boessenkool
2007-07-12 7:55 ` Kumar Gala
2007-07-12 8:27 ` Zang Roy-r61911
2007-07-12 9:00 ` Kumar Gala
2007-07-12 11:36 ` Zang Roy-r61911
2007-07-16 13:05 ` Segher Boessenkool
2007-07-16 14:29 ` Kumar Gala
2007-07-16 15:00 ` Segher Boessenkool
2007-07-17 1:43 ` Zang Roy-r61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB462F87-151E-4F21-80CF-209326FCEB67@kernel.crashing.org \
--to=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=segher@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox