From: "Danilo Krummrich" <dakr@kernel•org>
To: "Alex Williamson" <alex@shazbot•org>, "Jason Gunthorpe" <jgg@ziepe•ca>
Cc: "Russell King" <linux@armlinux•org.uk>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Rafael J. Wysocki" <rafael@kernel•org>,
"Ioana Ciornei" <ioana.ciornei@nxp•com>,
"Nipun Gupta" <nipun.gupta@amd•com>,
"Nikhil Agarwal" <nikhil.agarwal@amd•com>,
"K. Y. Srinivasan" <kys@microsoft•com>,
"Haiyang Zhang" <haiyangz@microsoft•com>,
"Wei Liu" <wei.liu@kernel•org>,
"Dexuan Cui" <decui@microsoft•com>,
"Long Li" <longli@microsoft•com>,
"Bjorn Helgaas" <bhelgaas@google•com>,
"Armin Wolf" <W_Armin@gmx•de>,
"Bjorn Andersson" <andersson@kernel•org>,
"Mathieu Poirier" <mathieu.poirier@linaro•org>,
"Vineeth Vijayan" <vneethv@linux•ibm.com>,
"Peter Oberparleiter" <oberpar@linux•ibm.com>,
"Heiko Carstens" <hca@linux•ibm.com>,
"Vasily Gorbik" <gor@linux•ibm.com>,
"Alexander Gordeev" <agordeev@linux•ibm.com>,
"Christian Borntraeger" <borntraeger@linux•ibm.com>,
"Sven Schnelle" <svens@linux•ibm.com>,
"Harald Freudenberger" <freude@linux•ibm.com>,
"Holger Dengler" <dengler@linux•ibm.com>,
"Mark Brown" <broonie@kernel•org>,
"Michael S. Tsirkin" <mst@redhat•com>,
"Jason Wang" <jasowang@redhat•com>,
"Xuan Zhuo" <xuanzhuo@linux•alibaba.com>,
"Eugenio Pérez" <eperezma@redhat•com>,
"Juergen Gross" <jgross@suse•com>,
"Stefano Stabellini" <sstabellini@kernel•org>,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam•com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel•org>,
linux-kernel@vger•kernel.org, driver-core@lists•linux.dev,
linuxppc-dev@lists•ozlabs.org, linux-hyperv@vger•kernel.org,
linux-pci@vger•kernel.org, platform-driver-x86@vger•kernel.org,
linux-arm-msm@vger•kernel.org, linux-remoteproc@vger•kernel.org,
linux-s390@vger•kernel.org, linux-spi@vger•kernel.org,
virtualization@lists•linux.dev, kvm@vger•kernel.org,
xen-devel@lists•xenproject.org,
linux-arm-kernel@lists•infradead.org,
"Danilo Krummrich" <dakr@kernel•org>,
"Gui-Dong Han" <hanguidong02@gmail•com>
Subject: Re: [PATCH 05/12] PCI: use generic driver_override infrastructure
Date: Mon, 30 Mar 2026 19:38:41 +0200 [thread overview]
Message-ID: <DHGATG6LJOM1.2AI7BYQ2O4DFU@kernel.org> (raw)
In-Reply-To: <20260324005919.2408620-6-dakr@kernel.org>
(Cc: Jason)
On Tue Mar 24, 2026 at 1:59 AM CET, Danilo Krummrich wrote:
> diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c
> index d43745fe4c84..460852f79f29 100644
> --- a/drivers/vfio/pci/vfio_pci_core.c
> +++ b/drivers/vfio/pci/vfio_pci_core.c
> @@ -1987,9 +1987,8 @@ static int vfio_pci_bus_notifier(struct notifier_block *nb,
> pdev->is_virtfn && physfn == vdev->pdev) {
> pci_info(vdev->pdev, "Captured SR-IOV VF %s driver_override\n",
> pci_name(pdev));
> - pdev->driver_override = kasprintf(GFP_KERNEL, "%s",
> - vdev->vdev.ops->name);
> - WARN_ON(!pdev->driver_override);
> + WARN_ON(device_set_driver_override(&pdev->dev,
> + vdev->vdev.ops->name));
Technically, this is a change in behavior. If vdev->vdev.ops->name is NULL, it
will trigger the WARN_ON(), whereas before it would have just written "(null)"
into driver_override.
I assume that vfio_pci_core drivers are expected to set the name in struct
vfio_device_ops in the first place and this code (silently) relies on this
invariant?
Alex, Jason: Should we keep this hunk above as is and check for a proper name in
struct vfio_device_ops in vfio_pci_core_register_device() with a subsequent
patch?
> } else if (action == BUS_NOTIFY_BOUND_DRIVER &&
> pdev->is_virtfn && physfn == vdev->pdev) {
> struct pci_driver *drv = pci_dev_driver(pdev);
next prev parent reply other threads:[~2026-03-30 17:38 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 0:59 [PATCH 00/12] treewide: Convert buses to use generic driver_override Danilo Krummrich
2026-03-24 0:59 ` [PATCH 01/12] amba: use generic driver_override infrastructure Danilo Krummrich
2026-03-24 0:59 ` [PATCH 02/12] bus: fsl-mc: " Danilo Krummrich
2026-03-25 12:01 ` Ioana Ciornei
2026-03-28 12:10 ` Christophe Leroy (CS GROUP)
2026-04-04 16:56 ` Christophe Leroy (CS GROUP)
2026-03-24 0:59 ` [PATCH 03/12] cdx: " Danilo Krummrich
2026-03-24 0:59 ` [PATCH 04/12] hv: vmbus: " Danilo Krummrich
2026-03-25 17:28 ` Michael Kelley
2026-04-04 15:01 ` [PATCH v2] Drivers: " Danilo Krummrich
2026-03-24 0:59 ` [PATCH 05/12] PCI: " Danilo Krummrich
2026-03-25 3:08 ` Gui-Dong Han
2026-03-26 18:08 ` Bjorn Helgaas
2026-03-30 16:28 ` Danilo Krummrich
2026-03-30 17:38 ` Danilo Krummrich [this message]
2026-03-30 20:10 ` Alex Williamson
2026-03-31 8:06 ` Danilo Krummrich
2026-03-31 8:22 ` Danilo Krummrich
2026-03-31 19:18 ` Alex Williamson
2026-03-24 0:59 ` [PATCH 06/12] platform/wmi: " Danilo Krummrich
2026-03-24 19:41 ` Armin Wolf
2026-03-31 15:02 ` Ilpo Järvinen
2026-03-31 15:43 ` Danilo Krummrich
2026-03-31 15:50 ` Ilpo Järvinen
2026-03-24 0:59 ` [PATCH 07/12] rpmsg: " Danilo Krummrich
2026-03-25 15:49 ` Mathieu Poirier
2026-03-24 0:59 ` [PATCH 08/12] vdpa: " Danilo Krummrich
2026-03-25 10:17 ` Eugenio Perez Martin
2026-03-24 0:59 ` [PATCH 09/12] s390/cio: " Danilo Krummrich
2026-03-26 9:43 ` Vineeth Vijayan
2026-03-24 0:59 ` [PATCH 10/12] s390/ap: " Danilo Krummrich
2026-03-24 12:41 ` Harald Freudenberger
2026-03-24 12:58 ` Holger Dengler
2026-03-24 0:59 ` [PATCH 11/12] spi: " Danilo Krummrich
2026-03-24 0:59 ` [PATCH 12/12] driver core: remove driver_set_override() Danilo Krummrich
2026-03-24 8:09 ` Greg Kroah-Hartman
2026-03-24 15:00 ` (subset) [PATCH 00/12] treewide: Convert buses to use generic driver_override Mark Brown
2026-03-25 9:29 ` Michael S. Tsirkin
2026-03-26 17:38 ` Danilo Krummrich
2026-04-04 15:07 ` (subset) " Danilo Krummrich
2026-04-04 16:58 ` Christophe Leroy (CS GROUP)
2026-04-04 17:04 ` Danilo Krummrich
2026-04-04 17:09 ` Christophe Leroy (CS GROUP)
2026-04-04 19:20 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHGATG6LJOM1.2AI7BYQ2O4DFU@kernel.org \
--to=dakr@kernel$(echo .)org \
--cc=W_Armin@gmx$(echo .)de \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=alex@shazbot$(echo .)org \
--cc=andersson@kernel$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=broonie@kernel$(echo .)org \
--cc=chleroy@kernel$(echo .)org \
--cc=decui@microsoft$(echo .)com \
--cc=dengler@linux$(echo .)ibm.com \
--cc=driver-core@lists$(echo .)linux.dev \
--cc=eperezma@redhat$(echo .)com \
--cc=freude@linux$(echo .)ibm.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=haiyangz@microsoft$(echo .)com \
--cc=hanguidong02@gmail$(echo .)com \
--cc=hca@linux$(echo .)ibm.com \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=jgg@ziepe$(echo .)ca \
--cc=jgross@suse$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kys@microsoft$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-remoteproc@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=longli@microsoft$(echo .)com \
--cc=mathieu.poirier@linaro$(echo .)org \
--cc=mst@redhat$(echo .)com \
--cc=nikhil.agarwal@amd$(echo .)com \
--cc=nipun.gupta@amd$(echo .)com \
--cc=oberpar@linux$(echo .)ibm.com \
--cc=oleksandr_tyshchenko@epam$(echo .)com \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
--cc=rafael@kernel$(echo .)org \
--cc=sstabellini@kernel$(echo .)org \
--cc=svens@linux$(echo .)ibm.com \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=vneethv@linux$(echo .)ibm.com \
--cc=wei.liu@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox