Subject: Re: [PATCH] POWERPC: mpc82xx merge: board-specific/platform stuff(resend)

From: Jon Loeliger <[email-masked]>
Date: Fri, 22 Sep 2006 12:20:10 -0500

So, like, the other day Vitaly Bordug mumbled:
> 
> This intruduces 82xx family in arch/powerpc/platforms,
> and has all the board-specific code to represent regression-less
> transaction from ppc. The functionality is apparently the same, including
> PCI controller.
> 
> Signed-off-by: Vitaly Bordug <[email-masked]>

Excellent!  Thanks!

> +++ b/arch/powerpc/platforms/82xx/mpc82xx_ads.c

> +/*
> + * Called very early, device-tree isn't unflattened
> + */
> +static int __init mpc82xx_ads_probe(void)
> +{
> +	/* We always match for now, eventually we should look at
> +	 * the flat dev tree to ensure this is the board we are
> +	 * supposed to run on
> +	 */
> +	return 1;
> +}

Please implement this routine fully.  Something down this line:

    {
        unsigned long root = of_get_flat_dt_root();

        if (of_flat_dt_is_compatible(root, "mpc82xx"))
            return 1;        /* Looks good */

        return 0;
    }

And with that, ACK me:

    Acked-by: Jon Loeliger <[email-masked]>

Thanks,
jdl