From: Jon Loeliger <jdl@jdl•com>
To: "Mark A. Greer" <mgreer@mvista•com>
Cc: linuxppc-dev <Linuxppc-dev@ozlabs•org>,
Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH/RFC] Add cmd_wrap_dts rules to arch/powerpc/boot/Makefile
Date: Thu, 19 Oct 2006 09:03:18 -0500 [thread overview]
Message-ID: <E1GaYUQ-0001jb-20@jdl.com> (raw)
In-Reply-To: Your message of "Wed, 18 Oct 2006 17:26:35 PDT." <20061019002635.GA2356@mag.az.mvista.com>
So, like, the other day "Mark A. Greer" mumbled:
>
> This would be used by the sandpoint, say, by adding the following rules
> to the Makefile in the appropriate places:
>
> $(obj)/zImage.sandpoint: vmlinux $(wrapperbits)
> $(call cmd,wrap_dts,sandpoint)
>
> $(obj)/zImage.initrd.sandpoint: vmlinux $(wrapperbits)
> $(call cmd,wrap_dts_initrd,sandpoint)
>
> and:
>
> image-$(CONFIG_SANDPOINT) += zImage.sandpoint
>
> Comments?
Isn't there a way to do this without hardcoding the
platform name in the makefiles directly? I fear for
the one-per-platform effect that is yet to come with
the conversion of many of the legacy boards.
> +++ b/arch/powerpc/boot/Makefile
> @@ -117,6 +117,13 @@ quiet_cmd_wrap = WRAP $@
> quiet_cmd_wrap_initrd = WRAP $@
> cmd_wrap_initrd =$(CONFIG_SHELL) $(wrapper) -c -o $@ -p $2 $(CROSSWRAP) \
> -i $(obj)/ramdisk.image.gz vmlinux
> +quiet_cmd_wrap_dts = WRAP_DTS $@
> + cmd_wrap_dts =$(CONFIG_SHELL) $(wrapper) -c -o $@ -p $2 $(CROSSWRAP) \
> + -s $(obj)/dts/$2.dts vmlinux
> +quiet_cmd_wrap_dts_initrd = WRAP_DTS $@
> + cmd_wrap_dts_initrd =$(CONFIG_SHELL) $(wrapper) -c -o $@ -p $2 \
> + $(CROSSWRAP) -s $(obj)/dts/$2.dts \
> + -i $(obj)/ramdisk.image.gz vmlinux
>
> $(obj)/zImage.chrp: vmlinux $(wrapperbits)
> $(call cmd,wrap,chrp)
Which I guess means this patch is OK, but the zImage.chrp use
around it is suspect.... :-)
jdl
next prev parent reply other threads:[~2006-10-19 14:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 0:26 [PATCH/RFC] Add cmd_wrap_dts rules to arch/powerpc/boot/Makefile Mark A. Greer
2006-10-19 0:34 ` Josh Boyer
2006-10-19 5:50 ` Matthew McClintock
2006-10-19 5:58 ` Matthew McClintock
2006-10-19 19:26 ` Mark A. Greer
2006-10-19 14:03 ` Jon Loeliger [this message]
2006-10-19 19:51 ` Mark A. Greer
2007-01-11 0:40 ` Mark A. Greer
2007-01-12 19:50 ` Jon Loeliger
2007-01-12 21:48 ` Mark A. Greer
2007-01-12 23:00 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1GaYUQ-0001jb-20@jdl.com \
--to=jdl@jdl$(echo .)com \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=mgreer@mvista$(echo .)com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox