From: Jon Loeliger <jdl@jdl•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: libfdt: a fix but still broken
Date: Fri, 23 Feb 2007 09:08:16 -0600 [thread overview]
Message-ID: <E1HKc1x-0001ze-0b@jdl.com> (raw)
In-Reply-To: Your message of "Fri, 23 Feb 2007 14:47:35 +1100." <20070223034734.GA18698@localhost.localdomain>
So, like, the other day David Gibson mumbled:
> On Thu, Feb 22, 2007 at 08:27:29AM -0500, Jerry Van Baren wrote:
> > Hi Dave,
> >
> > I have good news and bad news. ;-) The good news is that the
> > incompatibility between libfdt and jdl's dtc is that libfdt has the name
> > offset and the length of the name switched. booting_without_of.txt says
> > the length comes first, so libfdt is in the wrong.
>
> Ouch. That's.. a very embarrassing bug. Actually, I know where it
> came from: I was looking at flat_dt.h from dtc, which also gets this
> wrong (but the declaration in question is unused). Of course, I also
> wrote flat_dt.h ...
>
> > The bad news is that, when I fix this, nearly all of the tests fail (but
> > they fail the same way for both tree.S and jdl's dtc). I have not
> > started on that layer of the onion yet.
>
> Found it, there was a direct use of the position of the length in
> _fdt_next_tag(). Just pushed out a fix for this in the libfdt tree,
> along with some other small fixes which I found while tracking this
> one down.
>
> Oh, incidentally, I applied your patch by eye rather than with
> patch(1), which was handy, because it appears to have been whitespace
> damaged.
And amidst all of this, is there an actual DTC change needed?
I've not detected one yet, but I'm watching... :-)
jdl
next prev parent reply other threads:[~2007-02-23 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-22 13:27 libfdt: a fix but still broken Jerry Van Baren
2007-02-23 3:47 ` David Gibson
2007-02-23 12:59 ` Jerry Van Baren
2007-02-23 14:33 ` Jerry Van Baren
2007-02-23 22:24 ` David Gibson
2007-02-23 15:08 ` Jon Loeliger [this message]
2007-02-23 15:21 ` Jerry Van Baren
2007-02-23 22:47 ` David Gibson
2007-02-23 22:25 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1HKc1x-0001ze-0b@jdl.com \
--to=jdl@jdl$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox