From: Jon Loeliger <jdl@jdl•com>
To: Segher Boessenkool <segher@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] Add StorCenter DTS first draft.
Date: Tue, 17 Jul 2007 17:27:18 -0500 [thread overview]
Message-ID: <E1IAvVm-0005yQ-LO@jdl.com> (raw)
In-Reply-To: Your message of "Tue, 17 Jul 2007 16:57:27 +0200." <630B6BC9-389F-4F5C-AE8F-9C3131C4543E@kernel.crashing.org>
So, like, the other day Segher Boessenkool mumbled:
> > +/ {
> > + model = "StorCenter";
>
> If you can find a real model number, put it in here, instead.
Yep, "StorCenter" is it. No model numer/name beyond that.
> > + compatible = "storcenter";
>
> Needs a manufacturer name in there.
Right. Will use:
compatible = "iomega,storcenter"
> > + PowerPC,603e { /* Really 8241 */
>
> So say "PowerPC,8241@0", or "PowerPC,e300@0" (or whatever
> the CPU core in there is), or simply "cpu@0", following
> the generic naming recommended practice.
Well, its the 8241 SoC with a 603e core... (This is
the same phrase currently being used on the Kurobox.)
I'll use:
PowerPC,8241@0 }
> > + bus-frequency = <0>;
>
> Is this filled in anywhere? Please document that, if so.
Right. boot{loader,wrapper}
> > + soc10x {
>
> Bad name. Where is the binding for this? I don't think
> I saw it before.
It's what is being used, again, by the Kurobox. I understand
that doesn't make it "right", just precedented by now.
How about "soc8241@80000000" instead?
That would be similar to:
soc8641@f8000000 {
and
soc8272@f0000000 {
> > + store-gathering = <0>; /* 0 == off, !0 == on */
>
> Don't define this as "!0", but as "1".
OK.
> > + i2c@fdf03000 {
> > + device_type = "i2c";
>
> No device_type, there is no I2C binding.
Right.
> > + compatible = "fsl-i2c";
>
> Needs to be more specific.
Hmmm... Not sure what to use here then. There are many
existing examples using "fsl-i2c" already. Granted, we've
established that they could be wrong... Should this be
more like this?:
compatible = "fsl,mpc8241-i2c", "fsl-i2c";
> > + mpic: pic@fdf40000 {
>
> interrupt-controller@fdf40000
OK.
> > + pci@fe800000 {
> > + clock-frequency = <d# 100000000>; /* Hz */
>
> 100MHz PCI? Interesting.
Good point. 66666666 seems more likely...
Thanks for the review and help here!
jdl
next prev parent reply other threads:[~2007-07-17 22:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 14:22 [PATCH] Add StorCenter DTS first draft Jon Loeliger
2007-07-17 14:57 ` Segher Boessenkool
2007-07-17 16:26 ` Josh Boyer
2007-07-17 16:38 ` Segher Boessenkool
2007-07-17 22:27 ` Jon Loeliger [this message]
2007-07-17 22:34 ` Scott Wood
2007-07-17 22:56 ` Jon Loeliger
2007-07-18 16:19 ` Segher Boessenkool
2007-07-18 18:27 ` Kumar Gala
2007-07-19 17:03 ` Segher Boessenkool
2007-07-18 1:39 ` Benjamin Herrenschmidt
2007-07-18 16:13 ` Segher Boessenkool
2007-07-18 21:54 ` Benjamin Herrenschmidt
2007-07-19 16:05 ` Jon Loeliger
2007-07-19 17:07 ` Segher Boessenkool
2007-07-19 21:39 ` Benjamin Herrenschmidt
2007-07-20 7:14 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1IAvVm-0005yQ-LO@jdl.com \
--to=jdl@jdl$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=segher@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox