From: Jon Loeliger <jdl@jdl•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: libfdt: Fix handling of trailing / in fdt_path_offset()
Date: Thu, 30 Aug 2007 08:52:01 -0500 [thread overview]
Message-ID: <E1IQkRF-0004aU-Jh@jdl.com> (raw)
In-Reply-To: Your message of "Wed, 29 Aug 2007 12:22:50 +1000." <20070829022250.GA25468@localhost.localdomain>
So, like, the other day David Gibson mumbled:
> Currently, fdt_path_offset() returns FDL_ERR_BADOFFSET if given a path
> with a trailing '/'. In particular this means that
> fdt_path_offset("/") returns FDT_ERR_BADOFFSET rather than 0 as one
> would expect.
>
> This patch fixes the function to accept and ignore trailing '/'
> characters. As well as allowing fdt_path_offset("/") this means that
> fdt_path_offset("/foo/") will return the same as
> fdt_path_offset("/foo") which seems in keeping with the principle of
> least surprise.
>
> This also adds a testcase to ensure that fdt_path_offset("/") returns
> 0 as it should.
>
> Signed-off-by: David Gibson <david@gibson•dropbear.id.au>
Applied.
Thanks,
jdl
prev parent reply other threads:[~2007-08-30 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-29 2:22 libfdt: Fix handling of trailing / in fdt_path_offset() David Gibson
2007-08-30 13:52 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1IQkRF-0004aU-Jh@jdl.com \
--to=jdl@jdl$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox