From: Jon Loeliger <jdl@jdl•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [1/2] dtc: Refactor printing of property values in -Odts mode
Date: Thu, 08 Nov 2007 09:25:02 -0600 [thread overview]
Message-ID: <E1Iq9Fe-0002fW-CX@jdl.com> (raw)
In-Reply-To: Your message of "Wed, 07 Nov 2007 10:21:20 +1100." <20071106232120.GH31367@localhost.localdomain>
So, like, the other day David Gibson mumbled:
> Currently the main recursive tree printing function,
> write_tree_source_node(), calls guess_type() to apply heuristics to
> see how to print a property value, then calls the appropriate
> write_propval_*() function to print it.
>
> However, future heuristics for handling internal labels and the like
> don't work well this way. Therefore, this patch refactors things to
> have write_tree_source_node() call a new write_propval() function,
> which incorporates the heurstic logic from guess_type() and also calls
> the right function to do the actual printing.
>
> No behavioural change.
>
> Signed-off-by: David Gibson <david@gibson•dropbear.id.au>
Applied.
jdl
prev parent reply other threads:[~2007-11-08 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 23:21 [1/2] dtc: Refactor printing of property values in -Odts mode David Gibson
2007-11-06 23:22 ` [2/2] dtc: Make -Idts -Odts preserve property-internal labels David Gibson
2007-11-08 15:25 ` Jon Loeliger
2007-11-08 15:25 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Iq9Fe-0002fW-CX@jdl.com \
--to=jdl@jdl$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox