From: Jon Loeliger <jdl@jdl•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: libfdt: Abolish fdt_offset_ptr_typed()
Date: Tue, 20 Nov 2007 09:06:11 -0600 [thread overview]
Message-ID: <E1IuUfz-00021k-R8@jdl.com> (raw)
In-Reply-To: Your message of "Mon, 19 Nov 2007 17:26:22 +1100." <20071119062622.GL20794@localhost.localdomain>
So, like, the other day David Gibson mumbled:
> The fdt_offset_ptr_typed() macro seemed like a good idea at the time.
> However, it's not actually used all that often, it can silently throw
> away const qualifications and it uses a gcc extension (typeof) which
> I'd prefer to avoid for portability.
>
> Therefore, this patch gets rid of it (and the fdt_offset_ptr_typed_w()
> variant which was never used at all). It also makes a few variables
> const in testcases, which always should have been const, but weren't
> caught before because of the aforementioned silent discards.
>
> Signed-off-by: David Gibson <david@gibson•dropbear.id.au>
Applied.
jdl
prev parent reply other threads:[~2007-11-20 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 6:26 libfdt: Abolish fdt_offset_ptr_typed() David Gibson
2007-11-20 15:06 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1IuUfz-00021k-R8@jdl.com \
--to=jdl@jdl$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox