From: Jon Loeliger <jdl@jdl•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: dtc: Remove some redundant testcases
Date: Mon, 26 Nov 2007 15:21:10 -0600 [thread overview]
Message-ID: <E1IwlOA-0001cY-91@jdl.com> (raw)
In-Reply-To: Your message of "Wed, 21 Nov 2007 11:29:18 +1100." <20071121002918.GC13156@localhost.localdomain>
So, like, the other day David Gibson mumbled:
> This patch removes a number of testcases from the testsuite that are
> extremely unlikely to find any bugs that won't be found by the other
> tests. This speeds up the testsuite.
>
> - Both loops across the various tree block layouts run the
> tree1_tests on the basic mangled tree. This is completely redundant,
> so remove the second copy. This removes 456 testcases.
>
> - We currently run tree1_tests on various trees manipulated by
> move_and_save. We replace those with just a dtbs_equal_ordered test
> to check that the manipulated tree is equal to the original. What
> we're testing here is that fdt_move() operates correctly - it's very
> unlikely it would succeed well enough for the ordered_equal test to
> succeed, but the tree1_tests would fail on the result. This removes
> 162 testcases.
>
> - Currently we re-ordered with mangle-layout both the basic
> test_tree1.dtb and sw_tree1.test.dtb. Since we've already checked
> that these dtbs are equivalent with dtbs_ordered_equal, it's very
> unlikely that the tests would fail on one but not the other.
> Therefore reduce this to only using test_tree1.dtb. This removes 828
> testcases.
Applied.
Thanks,
jdl
prev parent reply other threads:[~2007-11-26 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 0:29 dtc: Remove some redundant testcases David Gibson
2007-11-26 21:21 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1IwlOA-0001cY-91@jdl.com \
--to=jdl@jdl$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox