public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed

From: Jon Loeliger <jdl@jdl•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: dtc: Flexible tree checking infrastructure (v2)
Date: Mon, 26 Nov 2007 16:13:32 -0600	[thread overview]
Message-ID: <E1IwmCq-0002g9-Nk@jdl.com> (raw)
In-Reply-To: Your message of "Thu, 22 Nov 2007 14:38:07 +1100." <20071122033807.GH19445@localhost.localdomain>

So, like, the other day David Gibson mumbled:
> dtc: Flexible tree checking infrastructure
> 
> Here, at last, is a substantial start on revising dtc's infrastructure
> for checking the tree; this is the rework I've been saying was
> necessary practically since dtc was first release.
> 
> In the new model, we have a table of "check" structures, each with a
> name, references to checking functions, and status variables.  Each
> check can (in principle) be individually switched off or on (as either
> a warning or error).  Checks have a list of prerequisites, so if
> checks need to rely on results from earlier checks to make sense (or
> even to avoid crashing) they just need to list the relevant other
> checks there.
> 
> For now, only the "structural" checks and the fixups for phandle
> references are converted to the new mechanism.  The rather more
> involved semantic checks (which is where this new mechanism will
> really be useful) will have to be converted in future patches.
> 
> At present, there's no user interface for turning on/off the checks -
> the -f option now forces output even if "error" level checks fail.
> Again, future patches will be needed to add the fine-grained control,
> but that should be quite straightforward with the infrastructure
> implemented here.
> 
> Also adds a testcase for the handling of bad references, which catches
> a bug encountered while developing this patch.
> 
> Signed-off-by: David Gibson <david@gibson•dropbear.id.au>

While I've Applied this one, it has introduced this:

         CC dtc.o
    dtc.c: In function 'main':
    dtc.c:199: warning: 'structure_ok' is used uninitialized in this function

Followup easy patch?

Thanks,
jdl

next prev parent reply	other threads:[~2007-11-26 22:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-21  5:38 dtc: Flexible tree checking infrastructure David Gibson
2007-11-22  3:38 ` dtc: Flexible tree checking infrastructure (v2) David Gibson
2007-11-26 22:13   ` Jon Loeliger [this message]
2007-11-27  3:58     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1IwmCq-0002g9-Nk@jdl.com \
    --to=jdl@jdl$(echo .)com \
    --cc=david@gibson$(echo .)dropbear.id.au \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox