From: Jon Loeliger <jdl@jdl•com>
To: Timur Tabi <timur@freescale•com>
Cc: linuxppc-dev@ozlabs•org, alsa-devel@alsa-project•org
Subject: Re: [PATCH] ASoC drivers for the Freescale MPC8610 SoC
Date: Thu, 20 Dec 2007 08:47:36 -0600 [thread overview]
Message-ID: <E1J5MgT-0008HO-13@jdl.com> (raw)
In-Reply-To: Your message of "Wed, 19 Dec 2007 18:03:09 CST." <11981089894052-git-send-email-timur@freescale.com>
So, like, the other day Timur Tabi mumbled:
> diff --git a/arch/powerpc/platforms/86xx/mpc8610_hpcd.c b/arch/powerpc/platforms/86xx/mpc8610_hpc
> d.c
> index 6390895..6e1bde3 100644
> --- a/arch/powerpc/platforms/86xx/mpc8610_hpcd.c
> +++ b/arch/powerpc/platforms/86xx/mpc8610_hpcd.c
> @@ -34,9 +34,27 @@
>
> #include <asm/mpic.h>
>
> +#include <asm/of_platform.h>
> #include <sysdev/fsl_pci.h>
> #include <sysdev/fsl_soc.h>
Please dont' re-introduce these. I just submitted patches to
move all of the PowerPC instances to using <linux/of_platform.h>
> diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
> new file mode 100644
> index 0000000..5421a5c
> --- /dev/null
> +++ b/sound/soc/fsl/mpc8610_hpcd.c
> @@ -0,0 +1,621 @@
> +/**
> + * Freescale MPC8610HPCD ALSA SoC Fabric driver
> + *
> + * Author: Timur Tabi <timur@freescale•com>
> + *
> + * Copyright 2007 Freescale Semiconductor, Inc. This file is licensed under
> + * the terms of the GNU General Public License version 2. This program
> + * is licensed "as is" without any warranty of any kind, whether express
> + * or implied.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/moduleparam.h>
> +#include <linux/version.h>
> +#include <linux/kernel.h>
> +#include <linux/interrupt.h>
> +#include <linux/platform_device.h>
> +#include <asm/of_device.h>
> +#include <asm/of_platform.h>
Again, this should be moved up as <linux/of_platform.h>.
Thanks,
jdl
next prev parent reply other threads:[~2007-12-20 14:47 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 0:03 [PATCH] ASoC drivers for the Freescale MPC8610 SoC Timur Tabi
2007-12-20 4:06 ` Olof Johansson
2007-12-20 14:24 ` Timur Tabi
2007-12-20 13:54 ` [alsa-devel] " Takashi Iwai
2007-12-20 17:04 ` Timur Tabi
2007-12-21 5:28 ` Lee Revell
2007-12-23 3:23 ` Timur Tabi
2007-12-20 22:39 ` Olof Johansson
2007-12-20 22:37 ` Timur Tabi
2007-12-20 22:43 ` Scott Wood
2007-12-23 2:58 ` Timur Tabi
2008-01-02 18:08 ` Scott Wood
2007-12-20 14:47 ` Jon Loeliger [this message]
2007-12-20 22:29 ` Jon Smirl
2007-12-20 22:32 ` Timur Tabi
2007-12-20 22:38 ` Jon Smirl
2007-12-20 22:40 ` Timur Tabi
2007-12-20 22:44 ` Scott Wood
2007-12-20 23:13 ` Jon Smirl
2007-12-21 0:00 ` David Gibson
2008-01-01 17:25 ` Jon Smirl
2008-01-01 17:42 ` Jon Smirl
2008-01-02 15:19 ` Timur Tabi
2008-01-02 15:34 ` Jon Smirl
2008-01-03 17:54 ` Timur Tabi
2008-01-03 18:13 ` Grant Likely
2008-01-03 18:20 ` Timur Tabi
2008-01-03 18:32 ` Grant Likely
2008-01-03 23:51 ` David Gibson
2008-01-05 2:39 ` [alsa-devel] " Timur Tabi
2008-01-06 0:46 ` David Gibson
2008-01-07 14:24 ` Mark Brown
2008-01-07 15:52 ` Timur Tabi
2008-01-07 18:28 ` Mark Brown
2008-01-10 3:49 ` David Gibson
2008-01-10 5:41 ` Jon Smirl
2008-01-10 10:30 ` Liam Girdwood
2008-01-10 15:39 ` Timur Tabi
2008-01-10 16:01 ` Grant Likely
2008-01-10 16:03 ` Timur Tabi
2008-01-10 20:10 ` Jon Smirl
2008-01-10 20:13 ` Timur Tabi
2008-01-10 20:24 ` Grant Likely
2008-01-10 20:35 ` Timur Tabi
2008-01-10 20:39 ` Jon Smirl
2008-01-10 20:44 ` Timur Tabi
2008-01-07 18:44 ` Liam Girdwood
2008-01-07 18:45 ` Timur Tabi
2008-01-02 16:12 ` Grant Likely
2008-01-03 18:08 ` Timur Tabi
2008-01-03 18:17 ` Grant Likely
2008-01-03 18:54 ` Scott Wood
2008-01-03 19:13 ` Grant Likely
2008-01-03 19:18 ` Scott Wood
2008-01-03 23:13 ` [alsa-devel] " Mark Brown
2008-01-05 2:35 ` Timur Tabi
2008-01-05 3:28 ` Grant Likely
2008-01-02 0:26 ` David Gibson
2008-01-02 15:10 ` Timur Tabi
2008-01-02 17:23 ` [alsa-devel] " Mark Brown
2008-01-03 18:23 ` Timur Tabi
2008-01-03 23:00 ` Mark Brown
2008-01-05 2:43 ` Timur Tabi
2008-01-07 13:37 ` Mark Brown
2008-01-02 4:27 ` Jon Smirl
2008-01-02 15:29 ` Timur Tabi
2008-01-02 15:56 ` Jon Smirl
2008-01-02 16:32 ` Grant Likely
2008-01-02 17:12 ` Jon Smirl
2008-01-02 17:22 ` Grant Likely
2008-01-02 18:43 ` Jon Smirl
2008-01-02 18:50 ` Grant Likely
2008-01-02 18:56 ` Jon Smirl
2008-01-03 4:46 ` David Gibson
2008-01-03 14:33 ` Jon Smirl
2008-01-03 17:57 ` Timur Tabi
2008-01-02 16:28 ` Grant Likely
2008-01-02 18:49 ` [alsa-devel] " Mark Brown
2008-01-03 18:16 ` Timur Tabi
2008-01-03 23:47 ` David Gibson
2008-01-04 13:39 ` Mark Brown
2008-01-03 18:14 ` Timur Tabi
2008-01-03 18:25 ` Grant Likely
2008-01-03 18:28 ` Timur Tabi
2008-01-03 18:38 ` Grant Likely
2008-01-03 4:44 ` David Gibson
2008-01-03 14:54 ` Jon Smirl
2008-01-04 5:01 ` David Gibson
2008-01-03 18:16 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1J5MgT-0008HO-13@jdl.com \
--to=jdl@jdl$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox