public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed

From: Jon Loeliger <jdl@jdl•com>
To: "Grant Likely" <grant.likely@secretlab•ca>
Cc: linuxppc-dev@ozlabs•org, andy@protium•com
Subject: Re: [RFC PATCH 1/3] Add StorCenter DTS first draft.
Date: Mon, 07 Jan 2008 14:09:09 -0600	[thread overview]
Message-ID: <E1JByHV-0007Lk-HK@jdl.com> (raw)
In-Reply-To: Your message of "Mon, 07 Jan 2008 12:26:13 MST." <fa686aa40801071126o1dd9798eub6006e1f0f33797f@mail.gmail.com>

So, like, the other day "Grant Likely" mumbled:
> > +
> > +               ranges = <80000000 80000000 70000000    /* pci mem space */
> > +                         fdf00000 fdf00000 00100000    /* EUMB */
> > +                         fe000000 fe000000 00c00000    /* pci i/o space */
> > +                         fec00000 fec00000 00300000    /* pci cfg regs */
> > +                         fef00000 fef00000 00100000>;  /* pci iack */
> 
> This doesn't look nice.  On the other ppc boards, Kumar moved the pci
> bus node out of the soc node so the the internal register range is
> separate from the soc.

Oh crap.  I forgot about that.  Yes, you are right.

> I think it should look like this:
> 
> {
>     soc@fdf00000 {
>         compatible = "fsl,mpc8241-immr";
>         ranges = <0 fe000000 00100000>;
>         serial@4500 {
>             blah....
>         };
>         blah....
>     };
>     pci@800000000 {
>         ranges = blah....
>     };
> };

So, I'll definitely rework that part as in indicated

> > +                       clock-frequency = <d# 97553800>; /* Hz */
> 
> That's kind of an odd number for clock frequency.  Usually clock
> frequencies are *big* and *round*.  :-)

And this one, according to Andy, is nice-n-measured right
off the crystal!  I had 10M in there originally even.
But I'll double check that with him to be sure.

Thanks,
jdl

     prev parent reply	other threads:[~2008-01-07 20:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-07 17:54 [RFC PATCH 1/3] Add StorCenter DTS first draft Jon Loeliger
2008-01-07 19:26 ` Grant Likely
2008-01-07 20:09   ` Jon Loeliger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1JByHV-0007Lk-HK@jdl.com \
    --to=jdl@jdl$(echo .)com \
    --cc=andy@protium$(echo .)com \
    --cc=grant.likely@secretlab$(echo .)ca \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox