From: Jon Loeliger <jdl@jdl•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: libfdt: Fix NOP handling bug in fdt_add_subnode_namelen()
Date: Thu, 14 Feb 2008 08:05:07 -0600 [thread overview]
Message-ID: <E1JPei3-0008KM-Pu@jdl.com> (raw)
In-Reply-To: Your message of "Thu, 14 Feb 2008 16:50:34 +1100." <20080214055034.GA13137@localhost.localdomain>
So, like, the other day David Gibson mumbled:
> fdt_add_subnode_namelen() has a bug if asked to add a subnode to a
> node which has NOP tags interspersed with its properties. In this
> case fdt_add_subnode_namelen() will put the new subnode before the
> first NOP tag, even if there are properties after it, which will
> result in an invalid blob.
>
> This patch fixes the bug, and adds a testcase for it.
>
> Signed-off-by: David Gibson <david@gibson•dropbear.id.au>
Applied.
Thanks,
jdl
prev parent reply other threads:[~2008-02-14 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 5:50 libfdt: Fix NOP handling bug in fdt_add_subnode_namelen() David Gibson
2008-02-14 14:05 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1JPei3-0008KM-Pu@jdl.com \
--to=jdl@jdl$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox