From: Jon Loeliger <jdl@jdl•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: libfdt: More tests of NOP handling behaviour
Date: Mon, 18 Feb 2008 08:24:56 -0600 [thread overview]
Message-ID: <E1JR6vQ-0000h9-2f@jdl.com> (raw)
In-Reply-To: Your message of "Mon, 18 Feb 2008 16:09:25 +1100." <20080218050925.GH29975@localhost.localdomain>
So, like, the other day David Gibson mumbled:
> In light of the recently discovered bug with NOP handling, this adds
> some more testcases for NOP handling. Specifically, it adds a helper
> program which will add a NOP tag after every existing tag in a dtb,
> and runs the standard battery of tests over trees mangled in this way.
>
> For now, this does not add a NOP at the very beginning of the
> structure block. This causes problems for libfdt at present, because
> we assume in many places that the root node's BEGIN_NODE tag is at
> offset 0. I'm still contemplating what to do about this (with one
> option being simply to declare such dtbs invalid).
>
> Signed-off-by: David Gibson <david@gibson•dropbear.id.au>
Applied.
BTW, declaring DTBs with BEGIN_NODES not at offset 0
as invalid seems like a fine choice to me.
jdl
next prev parent reply other threads:[~2008-02-18 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 5:09 libfdt: More tests of NOP handling behaviour David Gibson
2008-02-18 14:24 ` Jon Loeliger [this message]
2008-02-20 1:18 ` Jerry Van Baren
2008-02-20 2:04 ` David Gibson
2008-02-22 23:42 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1JR6vQ-0000h9-2f@jdl.com \
--to=jdl@jdl$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox