public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@jdl•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: dtc: Trivial formatting fixes
Date: Wed, 26 Mar 2008 08:15:35 -0500	[thread overview]
Message-ID: <E1JeVTb-0005tQ-Ae@jdl.com> (raw)
In-Reply-To: <20080326052103.GB2090@localhost.localdomain>

> This patch fixes some trivial indentation and brace/bracket style
> problems.


> @@ -179,9 +179,8 @@
>  		arg = argv[optind];
>  
>  	/* minsize and padsize are mutually exclusive */
> -	if ((minsize) && (padsize)) {
> +	if (minsize && padsize)
>  		die("Can't set both -p and -S\n");
> -	}


I do not consider extra braces a "problem", and will
not be applying those changes.  The other indentation
fixes will be applied, of course.

jdl

  reply	other threads:[~2008-03-26 13:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-26  5:21 dtc: Trivial formatting fixes David Gibson
2008-03-26 13:15 ` Jon Loeliger [this message]
2008-03-26 22:30   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1JeVTb-0005tQ-Ae@jdl.com \
    --to=jdl@jdl$(echo .)com \
    --cc=david@gibson$(echo .)dropbear.id.au \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox