From: Jon Loeliger <jdl@jdl•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: libfdt: Seval cleanups to parameter checking (v3)
Date: Thu, 29 May 2008 08:19:19 -0500 [thread overview]
Message-ID: <E1K1i2J-0006CN-HA@jdl.com> (raw)
In-Reply-To: <20080520071911.GR22279@yookeroo.seuss>
> Subject: Re: libfdt: Seval cleanups to parameter checking (v3)
Please put the "(v3)" in brackets at the begining of the Subject:.
> This patch makes a couple of small cleanups to parameter checking of
> libfdt functions.
>
> - In several functions which take a node offset, we use an
> idiom involving fdt_next_tag() first to check that we have indeed been
> given a node offset. This patch adds a helper function
> _fdt_check_node_offset() to encapsulate this usage of fdt_next_tag().
>
> - In fdt_rw.c in several places we have the expanded version
> of the RW_CHECK_HEADER() macro for no particular reason. This patch
> replaces those instances with an invocation of the macro; that's what
> it's for.
>
> - In fdt_sw.c we rename the check_header_sw() function to
> sw_check_header() to match the analgous function in fdt_rw.c, and we
> provide an SW_CHECK_HEADER() wrapper macro as RW_CHECK_HEADER()
> functions in fdt_rw.c
>
> Signed-off-by: David Gibson <david@gibson•dropbear.id.au>
Applied.
jdl
prev parent reply other threads:[~2008-05-29 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 6:33 libfdt: Seval cleanups to parameter checking (v2) David Gibson
2008-05-20 7:19 ` libfdt: Seval cleanups to parameter checking (v3) David Gibson
2008-05-29 13:19 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1K1i2J-0006CN-HA@jdl.com \
--to=jdl@jdl$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox