* [PATCH] dtc: give advance warning that "-S" is going away.
[not found] <E1KOBwm-0002vc-CT@jdl.com>
@ 2008-07-30 13:59 ` Paul Gortmaker
2008-07-30 14:03 ` Jon Loeliger
2008-07-31 15:43 ` Jon Loeliger
0 siblings, 2 replies; 3+ messages in thread
From: Paul Gortmaker @ 2008-07-30 13:59 UTC (permalink / raw)
To: devicetree-discuss; +Cc: linuxppc-dev, jdl, Paul Gortmaker
The "-S" option allowed the specification of a minimum size for
the blob, however the main reason for caring about the size is
so there is enough padding to add a chosen node by u-boot or
whoever. In which case, folks don't really care about the absolute
size, but rather the size of the padding added for this -- which
is what the "-p" option does. Having the "-S" just confuses people.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
---
dtc.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/dtc.c b/dtc.c
index d8fd43b..84bee2d 100644
--- a/dtc.c
+++ b/dtc.c
@@ -182,6 +182,9 @@ int main(int argc, char *argv[])
if (minsize && padsize)
die("Can't set both -p and -S\n");
+ if (minsize)
+ fprintf(stderr, "DTC: Use of \"-S\" is deprecated; it will be removed soon, use \"-p\" instead\n");
+
fprintf(stderr, "DTC: %s->%s on file \"%s\"\n",
inform, outform, arg);
--
1.5.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dtc: give advance warning that "-S" is going away.
2008-07-30 13:59 ` [PATCH] dtc: give advance warning that "-S" is going away Paul Gortmaker
@ 2008-07-30 14:03 ` Jon Loeliger
2008-07-31 15:43 ` Jon Loeliger
1 sibling, 0 replies; 3+ messages in thread
From: Jon Loeliger @ 2008-07-30 14:03 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linuxppc-dev, devicetree-discuss
> The "-S" option allowed the specification of a minimum size for
> the blob, however the main reason for caring about the size is
> so there is enough padding to add a chosen node by u-boot or
> whoever. In which case, folks don't really care about the absolute
> size, but rather the size of the padding added for this -- which
> is what the "-p" option does. Having the "-S" just confuses people.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
You rock.
> + if (minsize)
> + fprintf(stderr, "DTC: Use of \"-S\" is deprecated; it will be r
> emoved soon, use \"-p\" instead\n");
> +
Or use a U-boot that handles re-sizing automatically.
jdl
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dtc: give advance warning that "-S" is going away.
2008-07-30 13:59 ` [PATCH] dtc: give advance warning that "-S" is going away Paul Gortmaker
2008-07-30 14:03 ` Jon Loeliger
@ 2008-07-31 15:43 ` Jon Loeliger
1 sibling, 0 replies; 3+ messages in thread
From: Jon Loeliger @ 2008-07-31 15:43 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linuxppc-dev, devicetree-discuss
> The "-S" option allowed the specification of a minimum size for
> the blob, however the main reason for caring about the size is
> so there is enough padding to add a chosen node by u-boot or
> whoever. In which case, folks don't really care about the absolute
> size, but rather the size of the padding added for this -- which
> is what the "-p" option does. Having the "-S" just confuses people.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
Applied.
jdl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-31 15:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1KOBwm-0002vc-CT@jdl.com>
2008-07-30 13:59 ` [PATCH] dtc: give advance warning that "-S" is going away Paul Gortmaker
2008-07-30 14:03 ` Jon Loeliger
2008-07-31 15:43 ` Jon Loeliger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox