From: Jon Loeliger <jdl@jdl•com>
To: Anton Vorontsov <avorontsov@ru•mvista.com>
Cc: linuxppc-dev@ozlabs•org,
Jason Wessel <jason.wessel@windriver•com>,
Andy Fleming <afleming@freescale•com>,
David Miller <davem@davemloft•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH RFC] gianfar: Make polling safe with IRQs disabled
Date: Thu, 05 Nov 2009 08:01:10 -0600 [thread overview]
Message-ID: <E1N62ti-0003iS-K2@jdl.com> (raw)
In-Reply-To: <20091104225711.GA30844@oksana.dev.rtsoft.ru>
> When using KGDBoE, gianfar driver spits 'Interrupt problem' messages,
> which appears to be a legitimate warning, i.e. we may end up calling
> netif_receive_skb() or vlan_hwaccel_receive_skb() with IRQs disabled.
>
> This patch reworks the RX path so that if netpoll is enabled (the
> only case when the driver don't know from what context the polling
> may be called), we check whether IRQs are disabled, and if so we
> fall back to safe variants of skb receiving functions.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru•mvista.com>
> ---
>
> I'm not sure if this is suitable for mainline since it doesn't
> have KGDBoE support. Jason, if the patch is OK, would you like
> to merge it into KGDB tree?
It's a legitimate problem with or without KGDBoE. I see it
occasionally when conn_track is enabled as well, for example.
jdl
next prev parent reply other threads:[~2009-11-05 14:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 22:57 [PATCH RFC] gianfar: Make polling safe with IRQs disabled Anton Vorontsov
2009-11-05 14:01 ` Jon Loeliger [this message]
2009-11-05 14:20 ` Anton Vorontsov
2009-11-05 14:41 ` Jon Loeliger
2009-11-05 15:43 ` Jon Loeliger
2009-11-05 16:57 ` [PATCH RFC] gianfar: Do not call skb recycling with disabled IRQs Anton Vorontsov
2009-11-05 17:23 ` Kumar Gopalpet-B05799
2009-11-05 17:34 ` Anton Vorontsov
2009-11-05 17:40 ` Jon Loeliger
2009-11-05 17:53 ` Anton Vorontsov
2009-11-06 20:38 ` Jon Loeliger
2009-11-05 17:53 ` Kumar Gopalpet-B05799
2009-11-08 9:08 ` David Miller
2009-11-09 13:41 ` Anton Vorontsov
2009-11-08 9:05 ` [PATCH RFC] gianfar: Make polling safe with IRQs disabled David Miller
2009-11-09 13:32 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1N62ti-0003iS-K2@jdl.com \
--to=jdl@jdl$(echo .)com \
--cc=afleming@freescale$(echo .)com \
--cc=avorontsov@ru$(echo .)mvista.com \
--cc=davem@davemloft$(echo .)net \
--cc=jason.wessel@windriver$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox