From: Kumar Gala <kumar.gala@motorola•com>
To: "Yuxiao Xi" <xiyuxiao@harbournetworks•com>
Cc: <linuxppc-embedded@lists•linuxppc.org>
Subject: Re: question about UART ST16C2552
Date: Fri, 19 Sep 2003 01:24:14 -0500 [thread overview]
Message-ID: <E38F02EC-EA69-11D7-BE06-000393DBC2E8@motorola.com> (raw)
In-Reply-To: <200309190129.h8J1TcaJ006055@motgate5.mot.com>
Acutally, I misunderstood your question. The patch I've listed below
is to make the DUART on 8241/8245/8540 be detected correctly as a
16550A. The current code detects it as a startech uart.
diff -u -3 -t -p -r1.1.1.1 serial.c
--- serial.c 2003/09/05 22:29:42 1.1.1.1
+++ serial.c 2003/09/19 06:22:09
@@ -3741,13 +3741,17 @@ static void autoconfig(struct serial_sta
/* Check for Startech UART's */
serial_outp(info, UART_LCR, UART_LCR_DLAB);
if (serial_in(info, UART_EFR) == 0) {
- state->type = PORT_16650;
+ serial_outp(info, UART_EFR, 0xA8);
+ if (serial_in(info, UART_EFR) != 0)
+ state->type = PORT_16650;
+ serial_outp(info, UART_EFR, 0);
} else {
serial_outp(info, UART_LCR, 0xBF);
if (serial_in(info, UART_EFR) == 0)
autoconfig_startech_uarts(info, state,
flags);
}
}
- kumar
On Thursday, September 18, 2003, at 08:39 PM, Yuxiao Xi wrote:
> Yes,I have an external DUART ST16C2552.
> Kumar,should ST16C2552 be detected as 16550A?
> When and where can I get the patch for the on-chip UART you said?
> Thanks.
>
>
>
>
>
>> Thanks for the correction. I guess my comments really apply to 8241,
>> 8245 and 8540 then.
>>
>> - kumar
>>
>> On Thursday, September 18, 2003, at 11:23 AM, Milliorn Gary-rxcr80
>> wrote:
>>
>>> Kumar,
>>>
>>> There is no DUART on the MPC8240, if 8240 is what he literally
>>> meant. Some boards, like Unity, used to have an external DUART
>>> for this reason.
>>>
>>> Gary Milliorn
>>>
>>>
>>>
>>>> -----Original Message-----
>>>> From: Kumar Gala [mailto:kumar.gala@motorola•com]
>>>> Sent: Thursday, September 18, 2003 11:01 AM
>>>> To: Yuxiao Xi
>>>> Cc: linuxppc-embedded
>>>> Subject: Re: question about UART ST16C2552
>>>>
>>>>
>>>>
>>>> For 824x the detection code for the on-chip UART does NOT currently
>>>> detect it as a 16550A. There is a patch that Tom Rini and I are
>>>> working on getting accepted by the serial maintainers, that should
>>> fix
>>>> this.
>>>>
>>>> However, its not clear to me from your email if you also have a
>>>> ST16C2552 in addition to the DUART on the 8240.
>>>>
>>>> - kumar
>>>>
>
>
>
> ¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡Yuxiao Xi
> ¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡xiyuxiao@harbournetworks•com
> ¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡2003-09-19
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next parent reply other threads:[~2003-09-19 6:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200309190129.h8J1TcaJ006055@motgate5.mot.com>
2003-09-19 6:24 ` Kumar Gala [this message]
2003-09-19 1:39 question about UART ST16C2552 Yuxiao Xi
-- strict thread matches above, loose matches on Subject: below --
2003-09-18 16:23 Milliorn Gary-rxcr80
2003-09-18 16:29 ` Kumar Gala
2003-09-18 1:37 Yuxiao Xi
2003-09-18 16:00 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E38F02EC-EA69-11D7-BE06-000393DBC2E8@motorola.com \
--to=kumar.gala@motorola$(echo .)com \
--cc=linuxppc-embedded@lists$(echo .)linuxppc.org \
--cc=xiyuxiao@harbournetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox