Subject: Re: [PATCH 4/4] powerpc: remove orphaned MPC85xx kernel config fragments.

From: Paul Gortmaker <[email-masked]>
Date: Tue, 21 Feb 2023 16:29:32 -0500

[Re: [PATCH 4/4] powerpc: remove orphaned MPC85xx kernel config fragments.] On 21/02/2023 (Tue 21:03) Pali Roh??r wrote:

> On Tuesday 21 February 2023 14:46:37 Paul Gortmaker wrote:
> > None of these have a reference anymore anywhere, such as like this:
> > 
> >   arch/powerpc/Makefile:  $(call merge_into_defconfig,mpc85xx_base.config,\
> > 
> > As such, we probably should just clean up and remove them.
> > 
> > Cc: Scott Wood <[email-masked]>
> > Cc: Michael Ellerman <[email-masked]>
> > Cc: Benjamin Herrenschmidt <[email-masked]>
> > Cc: Paul Mackerras <[email-masked]>
> > Signed-off-by: Paul Gortmaker <[email-masked]>
> > ---
> >  arch/powerpc/configs/85xx-32bit.config |   5 -
> >  arch/powerpc/configs/85xx-hw.config    | 139 -------------------------
> >  arch/powerpc/configs/85xx-smp.config   |   2 -
> >  3 files changed, 146 deletions(-)
> >  delete mode 100644 arch/powerpc/configs/85xx-32bit.config
> >  delete mode 100644 arch/powerpc/configs/85xx-hw.config
> >  delete mode 100644 arch/powerpc/configs/85xx-smp.config
> 
> This change is likely going to break mpc85xx platform because defconfig
> files includes all these files which you are going to remove. For
> example in arch/powerpc/Makefile is:
> 
> PHONY += mpc85xx_smp_defconfig
> mpc85xx_smp_defconfig:
> 	$(call merge_into_defconfig,mpc85xx_base.config,\
> 		85xx-32bit 85xx-smp 85xx-hw fsl-emb-nonhw)

OK, it seems you've answered a question for me.  That being "why didn't
grep find a reference to these fragments?"

It seems the ".config" extension is optional?

This seems inconsistent at best, to reference some files with the
.config extension and others without it.  Not blaming you for that,
but it is probably something that needs looking into.

I am fine with dropping this config frag patch as we figure that out.

Paul.
--

> 
> And for P2020 boards I'm using mpc85xx_smp_defconfig configuration as
> this one compiles SMP kernel, ideal for P2020 which is dual-core SoC.