From: Arnaldo Carvalho de Melo <acme@kernel•org>
To: Ian Rogers <irogers@google•com>
Cc: ak@linux•intel.com, rnsastry@linux•ibm.com,
maddy@linux•vnet.ibm.com, linux-perf-users@vger•kernel.org,
Athira Rajeev <atrajeev@linux•vnet.ibm.com>,
james.clark@arm•com, jolsa@kernel•org, kjain@linux•ibm.com,
namhyung@kernel•org, disgoel@linux•ibm.com,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] powerpc/perf: Add json metric events to present CPI stall cycles in powerpc
Date: Fri, 17 Feb 2023 17:19:38 -0300 [thread overview]
Message-ID: <Y+/hWuRFPZwjcIxh@kernel.org> (raw)
In-Reply-To: <CAP-5=fWBb2=g82uVTkUbENThsnZyhzU+BHWVpuM7iYWDuA_TqA@mail.gmail.com>
Em Thu, Feb 16, 2023 at 10:10:05AM -0800, Ian Rogers escreveu:
> On Wed, Feb 15, 2023 at 10:12 PM Athira Rajeev
> <atrajeev@linux•vnet.ibm.com> wrote:
> >
> > Power10 Performance Monitoring Unit (PMU) provides events
> > to understand stall cycles of different pipeline stages.
> > These events along with completed instructions provides
> > useful metrics for application tuning.
> >
> > Patch implements the json changes to collect counter statistics
> > to present the high level CPI stall breakdown metrics. New metric
> > group is named as "CPI_STALL_RATIO" and this new metric group
> > presents these stall metrics:
> > - DISPATCHED_CPI ( Dispatch stall cycles per insn )
> > - ISSUE_STALL_CPI ( Issue stall cycles per insn )
> > - EXECUTION_STALL_CPI ( Execution stall cycles per insn )
> > - COMPLETION_STALL_CPI ( Completition stall cycles per insn )
> >
> > To avoid multipling of events, PM_RUN_INST_CMPL event has been
> > modified to use PMC5(performance monitoring counter5) instead
> > of PMC4. This change is needed, since completion stall event
> > is using PMC4.
> >
> > Usage example:
> >
> > ./perf stat --metric-no-group -M CPI_STALL_RATIO <workload>
> >
> > Performance counter stats for 'workload':
> >
> > 63,056,817,982 PM_CMPL_STALL # 0.28 COMPLETION_STALL_CPI
> > 1,743,988,038,896 PM_ISSUE_STALL # 7.73 ISSUE_STALL_CPI
> > 225,597,495,030 PM_RUN_INST_CMPL # 6.18 DISPATCHED_CPI
> > # 37.48 EXECUTION_STALL_CPI
> > 1,393,916,546,654 PM_DISP_STALL_CYC
> > 8,455,376,836,463 PM_EXEC_STALL
> >
> > "--metric-no-group" is used for forcing PM_RUN_INST_CMPL to be scheduled
> > in all group for more accuracy.
> >
> > Signed-off-by: Athira Rajeev <atrajeev@linux•vnet.ibm.com>
>
> Acked-by: Ian Rogers <irogers@google•com>
Thanks, applied.
- Arnaldo
prev parent reply other threads:[~2023-02-17 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 6:12 [PATCH] powerpc/perf: Add json metric events to present CPI stall cycles in powerpc Athira Rajeev
2023-02-16 18:10 ` Ian Rogers
2023-02-17 20:19 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+/hWuRFPZwjcIxh@kernel.org \
--to=acme@kernel$(echo .)org \
--cc=ak@linux$(echo .)intel.com \
--cc=atrajeev@linux$(echo .)vnet.ibm.com \
--cc=disgoel@linux$(echo .)ibm.com \
--cc=irogers@google$(echo .)com \
--cc=james.clark@arm$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kjain@linux$(echo .)ibm.com \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)vnet.ibm.com \
--cc=namhyung@kernel$(echo .)org \
--cc=rnsastry@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox