From: Arnaldo Carvalho de Melo <acme@kernel•org>
To: Ian Rogers <irogers@google•com>
Cc: maddy@linux•ibm.com, rnsastry@linux•ibm.com,
Kajol Jain <kjain@linux•ibm.com>,
linux-perf-users@vger•kernel.org, atrajeev@linux•vnet.ibm.com,
disgoel@linux•ibm.com, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2] tools/perf/tests: Change true workload to sleep workload in all metric test for system wide check
Date: Fri, 17 Feb 2023 17:22:53 -0300 [thread overview]
Message-ID: <Y+/iHQy9cWOP0ZtN@kernel.org> (raw)
In-Reply-To: <CAP-5=fWZxs432h_Vohe0WXaCATiUrTugpMzbYpKMseJpuj0h-g@mail.gmail.com>
Em Wed, Feb 15, 2023 at 08:08:20AM -0800, Ian Rogers escreveu:
> On Wed, Feb 15, 2023 at 1:38 AM Kajol Jain <kjain@linux•ibm.com> wrote:
> >
> > Testcase stat_all_metrics.sh fails in powerpc:
> >
> > 98: perf all metrics test : FAILED!
> >
> > Logs with verbose:
> >
> > [command]# ./perf test 98 -vv
> > 98: perf all metrics test :
> > --- start ---
> > test child forked, pid 13262
> > Testing BRU_STALL_CPI
> > Testing COMPLETION_STALL_CPI
> > ----
> > Testing TOTAL_LOCAL_NODE_PUMPS_P23
> > Metric 'TOTAL_LOCAL_NODE_PUMPS_P23' not printed in:
> > Error:
> > Invalid event (hv_24x7/PM_PB_LNS_PUMP23,chip=3/) in per-thread mode, enable system wide with '-a'.
> > Testing TOTAL_LOCAL_NODE_PUMPS_RETRIES_P01
> > Metric 'TOTAL_LOCAL_NODE_PUMPS_RETRIES_P01' not printed in:
> > Error:
> > Invalid event (hv_24x7/PM_PB_RTY_LNS_PUMP01,chip=3/) in per-thread mode, enable system wide with '-a'.
> > ----
> >
> > Based on above logs, we could see some of the hv-24x7 metric events fails,
> > and logs suggest to run the metric event with -a option.
> > This change happened after the commit a4b8cfcabb1d ("perf stat: Delay metric
> > parsing"), which delayed the metric parsing phase and now before metric parsing
> > phase perf tool identifies, whether target is system-wide or not. With this
> > change, perf_event_open will fails with workload monitoring for uncore events
> > as expected.
> >
> > The perf all metric test case fails as some of the hv-24x7 metric events
> > may need bigger workload with system wide monitoring to get the data.
> > Fix this issue by changing current system wide check from true workload to
> > sleep 0.01 workload.
> >
> > Result with the patch changes in powerpc:
> >
> > 98: perf all metrics test : Ok
> >
> > Reviewed-by: Athira Rajeev <atrajeev@linux•vnet.ibm.com>
> > Tested-by: Disha Goel <disgoel@linux•ibm.com>
> > Suggested-by: Ian Rogers <irogers@google•com>
> > Signed-off-by: Kajol Jain <kjain@linux•ibm.com>
>
> Tested-by: Ian Rogers <irogers@google•com>
>
> The mention of a4b8cfcabb1d can be moved to a Fixes tag so that this
> is backported.
Done, thanks, applied.
- Arnaldo
prev parent reply other threads:[~2023-02-17 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 9:38 [PATCH v2] tools/perf/tests: Change true workload to sleep workload in all metric test for system wide check Kajol Jain
2023-02-15 16:08 ` Ian Rogers
2023-02-17 20:22 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+/iHQy9cWOP0ZtN@kernel.org \
--to=acme@kernel$(echo .)org \
--cc=atrajeev@linux$(echo .)vnet.ibm.com \
--cc=disgoel@linux$(echo .)ibm.com \
--cc=irogers@google$(echo .)com \
--cc=kjain@linux$(echo .)ibm.com \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=rnsastry@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox