From: Greg KH <gregkh@linuxfoundation•org>
To: Dawei Li <set_pte_at@outlook•com>
Cc: jgross@suse•com, wei.liu@kernel•org, sstabellini@kernel•org,
linux-hyperv@vger•kernel.org, haiyangz@microsoft•com,
linuxppc-dev@lists•ozlabs.org, decui@microsoft•com,
alsa-devel@alsa-project•org, npiggin@gmail•com,
linux-kernel@vger•kernel.org, oleksandr_tyshchenko@epam•com,
srinivas.kandagatla@linaro•org, bgoswami@quicinc•com,
xen-devel@lists•xenproject.org, johannes@sipsolutions•net,
kys@microsoft•com, robert.jarzmik@free•fr, roger.pau@citrix•com
Subject: Re: [PATCH 6/6] soundbus: make remove callback of soundbus driver void returned
Date: Mon, 5 Dec 2022 17:07:52 +0100 [thread overview]
Message-ID: <Y44XWIqnKwE7ntPL@kroah.com> (raw)
In-Reply-To: <TYCP286MB2323BBFCE929111043E60D3BCA189@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
On Mon, Dec 05, 2022 at 11:36:44PM +0800, Dawei Li wrote:
> Since commit fc7a6209d571 ("bus: Make remove callback return
> void") forces bus_type::remove be void-returned, it doesn't
> make much sense for any bus based driver implementing remove
> callbalk to return non-void to its caller.
>
> This change is for soundbus based drivers.
>
> Signed-off-by: Dawei Li <set_pte_at@outlook•com>
> ---
> sound/aoa/fabrics/layout.c | 3 +--
> sound/aoa/soundbus/soundbus.h | 6 +++---
> 2 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/sound/aoa/fabrics/layout.c b/sound/aoa/fabrics/layout.c
> index ec4ef18555bc..850dc8c53e9b 100644
> --- a/sound/aoa/fabrics/layout.c
> +++ b/sound/aoa/fabrics/layout.c
> @@ -1094,7 +1094,7 @@ static int aoa_fabric_layout_probe(struct soundbus_dev *sdev)
> return -ENODEV;
> }
>
> -static int aoa_fabric_layout_remove(struct soundbus_dev *sdev)
> +static void aoa_fabric_layout_remove(struct soundbus_dev *sdev)
> {
> struct layout_dev *ldev = dev_get_drvdata(&sdev->ofdev.dev);
> int i;
> @@ -1123,7 +1123,6 @@ static int aoa_fabric_layout_remove(struct soundbus_dev *sdev)
> kfree(ldev);
> sdev->pcmid = -1;
> sdev->pcmname = NULL;
> - return 0;
> }
>
> #ifdef CONFIG_PM_SLEEP
> diff --git a/sound/aoa/soundbus/soundbus.h b/sound/aoa/soundbus/soundbus.h
> index 3a99c1f1a3ca..230dfa1ba270 100644
> --- a/sound/aoa/soundbus/soundbus.h
> +++ b/sound/aoa/soundbus/soundbus.h
> @@ -184,10 +184,10 @@ struct soundbus_driver {
>
> /* we don't implement any matching at all */
>
> - int (*probe)(struct soundbus_dev* dev);
> - int (*remove)(struct soundbus_dev* dev);
> + int (*probe)(struct soundbus_dev *dev);
Why change this line too?
thanks,
greg k-h
prev parent reply other threads:[~2022-12-05 16:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221205153644.60909-1-set_pte_at@outlook.com>
2022-12-05 15:36 ` [PATCH 1/6] hyperv: Make remove callback of hyperv driver void returned Dawei Li
2022-12-05 22:55 ` kernel test robot
2022-12-06 11:37 ` Wei Liu
2022-12-06 14:17 ` Dawei Li
2022-12-05 15:36 ` [PATCH 2/6] macio: Make remove callback of macio " Dawei Li
2022-12-05 16:08 ` Greg KH
2022-12-05 15:36 ` [PATCH 3/6] apr: make remove callback of apr " Dawei Li
2022-12-05 15:36 ` [PATCH 4/6] xen: make remove callback of xen " Dawei Li
2022-12-05 15:47 ` Juergen Gross
2022-12-05 16:02 ` Greg KH
2022-12-05 15:36 ` [PATCH 5/6] ac97: make remove callback of ac97 " Dawei Li
2022-12-05 16:03 ` Greg KH
2022-12-05 15:36 ` [PATCH 6/6] soundbus: make remove callback of soundbus " Dawei Li
2022-12-05 16:07 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y44XWIqnKwE7ntPL@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=bgoswami@quicinc$(echo .)com \
--cc=decui@microsoft$(echo .)com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=jgross@suse$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kys@microsoft$(echo .)com \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=npiggin@gmail$(echo .)com \
--cc=oleksandr_tyshchenko@epam$(echo .)com \
--cc=robert.jarzmik@free$(echo .)fr \
--cc=roger.pau@citrix$(echo .)com \
--cc=set_pte_at@outlook$(echo .)com \
--cc=srinivas.kandagatla@linaro$(echo .)org \
--cc=sstabellini@kernel$(echo .)org \
--cc=wei.liu@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox