From: Greg KH <gregkh@linuxfoundation•org>
To: Masahiro Yamada <masahiroy@kernel•org>
Cc: linuxppc-dev@lists•ozlabs.org, linux-kbuild@vger•kernel.org,
Mat Martineau <mathew.j.martineau@linux•intel.com>,
Matthias Maennich <maennich@google•com>,
linux-kernel@vger•kernel.org, mptcp@lists•linux.dev,
Jakub Kicinski <kuba@kernel•org>,
netdev@vger•kernel.org, Paul Mackerras <paulus@samba•org>,
linux-kselftest@vger•kernel.org,
Matthieu Baerts <matthieu.baerts@tessares•net>,
Shuah Khan <shuah@kernel•org>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH v2] kbuild: replace LANG=C with LC_ALL=C
Date: Fri, 30 Apr 2021 08:02:11 +0200 [thread overview]
Message-ID: <YIudYzwMq18AS8nB@kroah.com> (raw)
In-Reply-To: <20210430015627.65738-1-masahiroy@kernel.org>
On Fri, Apr 30, 2021 at 10:56:27AM +0900, Masahiro Yamada wrote:
> LANG gives a weak default to each LC_* in case it is not explicitly
> defined. LC_ALL, if set, overrides all other LC_* variables.
>
> LANG < LC_CTYPE, LC_COLLATE, LC_MONETARY, LC_NUMERIC, ... < LC_ALL
>
> This is why documentation such as [1] suggests to set LC_ALL in build
> scripts to get the deterministic result.
>
> LANG=C is not strong enough to override LC_* that may be set by end
> users.
>
> [1]: https://reproducible-builds.org/docs/locales/
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel•org>
> Acked-by: Michael Ellerman <mpe@ellerman•id.au> (powerpc)
> Reviewed-by: Matthias Maennich <maennich@google•com>
> Acked-by: Matthieu Baerts <matthieu.baerts@tessares•net> (mptcp)
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
prev parent reply other threads:[~2021-04-30 6:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 1:56 [PATCH v2] kbuild: replace LANG=C with LC_ALL=C Masahiro Yamada
2021-04-30 6:02 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIudYzwMq18AS8nB@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maennich@google$(echo .)com \
--cc=masahiroy@kernel$(echo .)org \
--cc=mathew.j.martineau@linux$(echo .)intel.com \
--cc=matthieu.baerts@tessares$(echo .)net \
--cc=mptcp@lists$(echo .)linux.dev \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulus@samba$(echo .)org \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox