From: David Gibson <david@gibson•dropbear.id.au>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux•ibm.com>
Cc: Nathan Lynch <nathanl@linux•ibm.com>,
Daniel Henrique Barboza <danielhb413@gmail•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [RFC PATCH 6/8] powerpc/pseries: Add a helper for form1 cpu distance
Date: Tue, 15 Jun 2021 13:21:59 +1000 [thread overview]
Message-ID: <YMgc1z63ejhHEHsM@yekko> (raw)
In-Reply-To: <20210614164003.196094-7-aneesh.kumar@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]
On Mon, Jun 14, 2021 at 10:10:01PM +0530, Aneesh Kumar K.V wrote:
> This helper is only used with the dispatch trace log collection.
> A later patch will add Form2 affinity support and this change helps
> in keeping that simpler. Also add a comment explaining we don't expect
> the code to be called with FORM0
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux•ibm.com>
Reviewed-by: David Gibson <david@gibson•dropbear.id.au>
> ---
> arch/powerpc/mm/numa.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index 64caaf07cf82..696e5bfe1414 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -166,7 +166,7 @@ static void unmap_cpu_from_node(unsigned long cpu)
> }
> #endif /* CONFIG_HOTPLUG_CPU || CONFIG_PPC_SPLPAR */
>
> -int cpu_distance(__be32 *cpu1_assoc, __be32 *cpu2_assoc)
> +static int __cpu_form1_distance(__be32 *cpu1_assoc, __be32 *cpu2_assoc)
> {
> int dist = 0;
>
> @@ -182,6 +182,14 @@ int cpu_distance(__be32 *cpu1_assoc, __be32 *cpu2_assoc)
> return dist;
> }
>
> +int cpu_distance(__be32 *cpu1_assoc, __be32 *cpu2_assoc)
> +{
> + /* We should not get called with FORM0 */
> + VM_WARN_ON(affinity_form == FORM0_AFFINITY);
> +
> + return __cpu_form1_distance(cpu1_assoc, cpu2_assoc);
> +}
> +
> /* must hold reference to node during call */
> static const __be32 *of_get_associativity(struct device_node *dev)
> {
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-15 3:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 16:39 [RFC PATCH 0/8] Add support for FORM2 associativity Aneesh Kumar K.V
2021-06-14 16:39 ` [RFC PATCH 1/8] powerpc/pseries: rename min_common_depth to primary_domain_index Aneesh Kumar K.V
2021-06-15 3:00 ` David Gibson
2021-06-15 8:21 ` Aneesh Kumar K.V
2021-06-14 16:39 ` [RFC PATCH 2/8] powerpc/pseries: rename distance_ref_points_depth to max_domain_index Aneesh Kumar K.V
2021-06-15 3:01 ` David Gibson
2021-06-15 8:22 ` Aneesh Kumar K.V
2021-06-14 16:39 ` [RFC PATCH 3/8] powerpc/pseries: Rename TYPE1_AFFINITY to FORM1_AFFINITY Aneesh Kumar K.V
2021-06-15 3:04 ` David Gibson
2021-06-14 16:39 ` [RFC PATCH 4/8] powerpc/pseries: Consolidate DLPAR NUMA distance update Aneesh Kumar K.V
2021-06-15 3:13 ` David Gibson
2021-06-15 8:26 ` Aneesh Kumar K.V
2021-06-14 16:40 ` [RFC PATCH 5/8] powerpc/pseries: Consolidate NUMA distance update during boot Aneesh Kumar K.V
2021-06-14 16:40 ` [RFC PATCH 6/8] powerpc/pseries: Add a helper for form1 cpu distance Aneesh Kumar K.V
2021-06-15 3:21 ` David Gibson [this message]
2021-06-14 16:40 ` [RFC PATCH 7/8] powerpc/pseries: Add support for FORM2 associativity Aneesh Kumar K.V
2021-06-15 3:53 ` David Gibson
2021-06-15 5:28 ` Aneesh Kumar K.V
2021-06-15 6:25 ` David Gibson
2021-06-15 7:40 ` Aneesh Kumar K.V
2021-06-17 7:50 ` David Gibson
2021-06-17 10:46 ` Aneesh Kumar K.V
2021-06-14 16:40 ` [RFC PATCH 8/8] powerpc/papr_scm: Use FORM2 associativity details Aneesh Kumar K.V
2021-06-15 3:55 ` David Gibson
2021-06-15 5:57 ` Aneesh Kumar K.V
2021-06-15 6:34 ` David Gibson
2021-06-15 7:05 ` Aneesh Kumar K.V
2021-06-17 7:46 ` David Gibson
2021-06-17 10:53 ` Daniel Henrique Barboza
2021-06-17 11:11 ` Aneesh Kumar K.V
2021-06-17 11:46 ` Aneesh Kumar K.V
2021-06-17 20:00 ` Daniel Henrique Barboza
2021-06-18 3:18 ` Aneesh Kumar K.V
2021-06-17 10:59 ` Aneesh Kumar K.V
2021-06-24 3:16 ` David Gibson
2021-06-17 13:55 ` Aneesh Kumar K.V
2021-06-17 14:04 ` Aneesh Kumar K.V
2021-06-15 1:47 ` [RFC PATCH 0/8] Add support for FORM2 associativity Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMgc1z63ejhHEHsM@yekko \
--to=david@gibson$(echo .)dropbear.id.au \
--cc=aneesh.kumar@linux$(echo .)ibm.com \
--cc=danielhb413@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nathanl@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox