From: Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>
To: Claire Chang <tientzu@chromium•org>
Cc: heikki.krogerus@linux•intel.com,
thomas.hellstrom@linux•intel.com, peterz@infradead•org,
joonas.lahtinen@linux•intel.com, dri-devel@lists•freedesktop.org,
chris@chris-wilson•co.uk, grant.likely@arm•com, paulus@samba•org,
Frank Rowand <frowand.list@gmail•com>,
mingo@kernel•org, Marek Szyprowski <m.szyprowski@samsung•com>,
sstabellini@kernel•org, Saravana Kannan <saravanak@google•com>,
Joerg Roedel <joro@8bytes•org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel•com>,
Christoph Hellwig <hch@lst•de>,
Bartosz Golaszewski <bgolaszewski@baylibre•com>,
bskeggs@redhat•com, linux-pci@vger•kernel.org,
xen-devel@lists•xenproject.org,
Thierry Reding <treding@nvidia•com>,
intel-gfx@lists•freedesktop.org, matthew.auld@intel•com,
linux-devicetree <devicetree@vger•kernel.org>,
jxgao@google•com, daniel@ffwll•ch, Will Deacon <will@kernel•org>,
maarten.lankhorst@linux•intel.com, airlied@linux•ie,
Dan Williams <dan.j.williams@intel•com>,
linuxppc-dev@lists•ozlabs.org, jani.nikula@linux•intel.com,
Rob Herring <robh+dt@kernel•org>,
rodrigo.vivi@intel•com, bhelgaas@google•com,
boris.ostrovsky@oracle•com,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
jgross@suse•com, Nicolas Boichat <drinkcat@chromium•org>,
Greg KH <gregkh@linuxfoundation•org>,
Randy Dunlap <rdunlap@infradead•org>,
lkml <linux-kernel@vger•kernel.org>,
tfiga@chromium•org,
"list@263•net:IOMMU DRIVERS" <iommu@lists•linux-foundation.org>,
Jim Quinlan <james.quinlan@broadcom•com>,
xypron.glpk@gmx•de, thomas.lendacky@amd•com,
Robin Murphy <robin.murphy@arm•com>,
bauerman@linux•ibm.com
Subject: Re: [PATCH v14 00/12] Restricted DMA
Date: Wed, 23 Jun 2021 04:38:07 -0400 [thread overview]
Message-ID: <YNLy7z0Zq1AXKLng@char.us.oracle.com> (raw)
In-Reply-To: <20210619034043.199220-1-tientzu@chromium.org>
On Sat, Jun 19, 2021 at 11:40:31AM +0800, Claire Chang wrote:
> This series implements mitigations for lack of DMA access control on
> systems without an IOMMU, which could result in the DMA accessing the
> system memory at unexpected times and/or unexpected addresses, possibly
> leading to data leakage or corruption.
>
> For example, we plan to use the PCI-e bus for Wi-Fi and that PCI-e bus is
> not behind an IOMMU. As PCI-e, by design, gives the device full access to
> system memory, a vulnerability in the Wi-Fi firmware could easily escalate
> to a full system exploit (remote wifi exploits: [1a], [1b] that shows a
> full chain of exploits; [2], [3]).
>
> To mitigate the security concerns, we introduce restricted DMA. Restricted
> DMA utilizes the existing swiotlb to bounce streaming DMA in and out of a
> specially allocated region and does memory allocation from the same region.
> The feature on its own provides a basic level of protection against the DMA
> overwriting buffer contents at unexpected times. However, to protect
> against general data leakage and system memory corruption, the system needs
> to provide a way to restrict the DMA to a predefined memory region (this is
> usually done at firmware level, e.g. MPU in ATF on some ARM platforms [4]).
>
> [1a] https://googleprojectzero.blogspot.com/2017/04/over-air-exploiting-broadcoms-wi-fi_4.html
> [1b] https://googleprojectzero.blogspot.com/2017/04/over-air-exploiting-broadcoms-wi-fi_11.html
> [2] https://blade.tencent.com/en/advisories/qualpwn/
> [3] https://www.bleepingcomputer.com/news/security/vulnerabilities-found-in-highly-popular-firmware-for-wifi-chips/
> [4] https://github.com/ARM-software/arm-trusted-firmware/blob/master/plat/mediatek/mt8183/drivers/emi_mpu/emi_mpu.c#L132
Heya Claire,
I put all your patches on
https://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb.git/log/?h=devel/for-linus-5.14
Please double-check that they all look ok.
Thank you!
next prev parent reply other threads:[~2021-06-23 8:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 3:40 [PATCH v14 00/12] Restricted DMA Claire Chang
2021-06-19 3:40 ` [PATCH v14 01/12] swiotlb: Refactor swiotlb init functions Claire Chang
2021-06-22 21:02 ` Stefano Stabellini
2021-06-19 3:40 ` [PATCH v14 02/12] swiotlb: Refactor swiotlb_create_debugfs Claire Chang
2021-06-19 3:40 ` [PATCH v14 03/12] swiotlb: Set dev->dma_io_tlb_mem to the swiotlb pool used Claire Chang
2021-06-19 3:40 ` [PATCH v14 04/12] swiotlb: Update is_swiotlb_buffer to add a struct device argument Claire Chang
2021-06-19 3:40 ` [PATCH v14 05/12] swiotlb: Update is_swiotlb_active " Claire Chang
2021-06-19 3:40 ` [PATCH v14 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing Claire Chang
2021-06-23 16:39 ` Qian Cai
2021-06-23 18:37 ` Will Deacon
2021-06-23 18:44 ` Qian Cai
2021-06-24 5:43 ` Christoph Hellwig
2021-06-24 6:05 ` Claire Chang
2021-06-24 11:14 ` Robin Murphy
2021-06-24 11:18 ` Will Deacon
2021-06-24 11:34 ` Robin Murphy
2021-06-24 11:48 ` Will Deacon
2021-06-24 14:10 ` Qian Cai
2021-06-24 15:55 ` Konrad Rzeszutek Wilk
2021-06-24 15:58 ` Claire Chang
2021-06-24 19:20 ` Konrad Rzeszutek Wilk
2021-06-19 3:40 ` [PATCH v14 07/12] swiotlb: Move alloc_size to swiotlb_find_slots Claire Chang
2021-06-19 3:40 ` [PATCH v14 08/12] swiotlb: Refactor swiotlb_tbl_unmap_single Claire Chang
2021-06-19 3:40 ` [PATCH v14 09/12] swiotlb: Add restricted DMA alloc/free support Claire Chang
2021-06-19 3:40 ` [PATCH v14 10/12] swiotlb: Add restricted DMA pool initialization Claire Chang
2021-06-19 3:40 ` [PATCH v14 11/12] dt-bindings: of: Add restricted DMA pool Claire Chang
2021-06-19 3:40 ` [PATCH v14 12/12] of: Add plumbing for " Claire Chang
2021-06-23 8:38 ` Konrad Rzeszutek Wilk [this message]
2021-06-23 9:01 ` [PATCH v14 00/12] Restricted DMA Claire Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNLy7z0Zq1AXKLng@char.us.oracle.com \
--to=konrad.wilk@oracle$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=bauerman@linux$(echo .)ibm.com \
--cc=bgolaszewski@baylibre$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=bskeggs@redhat$(echo .)com \
--cc=chris@chris-wilson$(echo .)co.uk \
--cc=dan.j.williams@intel$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=drinkcat@chromium$(echo .)org \
--cc=frowand.list@gmail$(echo .)com \
--cc=grant.likely@arm$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hch@lst$(echo .)de \
--cc=heikki.krogerus@linux$(echo .)intel.com \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=james.quinlan@broadcom$(echo .)com \
--cc=jani.nikula@linux$(echo .)intel.com \
--cc=jgross@suse$(echo .)com \
--cc=joonas.lahtinen@linux$(echo .)intel.com \
--cc=joro@8bytes$(echo .)org \
--cc=jxgao@google$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=matthew.auld@intel$(echo .)com \
--cc=mingo@kernel$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=robh+dt@kernel$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=rodrigo.vivi@intel$(echo .)com \
--cc=saravanak@google$(echo .)com \
--cc=sstabellini@kernel$(echo .)org \
--cc=tfiga@chromium$(echo .)org \
--cc=thomas.hellstrom@linux$(echo .)intel.com \
--cc=thomas.lendacky@amd$(echo .)com \
--cc=tientzu@chromium$(echo .)org \
--cc=treding@nvidia$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
--cc=xypron.glpk@gmx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox