Subject: Re: [PATCH v4 5/5] bus: Make remove callback return void

From: Wolfram Sang <[email-masked]>
Date: Tue, 20 Jul 2021 22:25:42 +0200

On Tue, Jul 13, 2021 at 09:35:22PM +0200, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
> 
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
> 
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
> 
> Acked-by: Russell King (Oracle) <[email-masked]> (For ARM, Amba and related parts)
> Acked-by: Mark Brown <[email-masked]>
> Acked-by: Chen-Yu Tsai <[email-masked]> (for sunxi-rsb)
> Acked-by: Pali Rohár <[email-masked]>
> Acked-by: Mauro Carvalho Chehab <[email-masked]> (for media)
> Acked-by: Hans de Goede <[email-masked]> (For drivers/platform)
> Acked-by: Alexandre Belloni <[email-masked]>
> Acked-By: Vinod Koul <[email-masked]>
> Acked-by: Juergen Gross <[email-masked]> (For xen)
> Acked-by: Lee Jones <[email-masked]> (For mfd)
> Acked-by: Johannes Thumshirn <[email-masked]> (For mcb)
> Acked-by: Johan Hovold <[email-masked]>
> Acked-by: Srinivas Kandagatla <[email-masked]> (For slimbus)
> Acked-by: Kirti Wankhede <[email-masked]> (For vfio)
> Acked-by: Maximilian Luz <[email-masked]>
> Acked-by: Heikki Krogerus <[email-masked]> (For ulpi and typec)
> Acked-by: Samuel Iglesias Gonsálvez <[email-masked]> (For ipack)
> Reviewed-by: Tom Rix <[email-masked]> (For fpga)
> Acked-by: Geoff Levand <[email-masked]> (For ps3)
> Acked-by: Yehezkel Bernat <[email-masked]> (For thunderbolt)
> Reviewed-by: Mathieu Poirier <[email-masked]>
> Acked-by: Alexander Shishkin <[email-masked]> (For intel_th)
> Acked-by: Dominik Brodowski <[email-masked]> (For pcmcia)
> Reviewed-by: Cornelia Huck <[email-masked]> (For drivers/s390 and drivers/vfio)
> Acked-by: Rafael J. Wysocki <[email-masked]> (For ACPI)
> Acked-by: Bjorn Andersson <[email-masked]> (rpmsg and apr)
> Acked-by: Srinivas Pandruvada <[email-masked]> (For intel-ish-hid)
> Acked-by: Dan Williams <[email-masked]> (For CXL, DAX, and NVDIMM)
> Acked-by: William Breathitt Gray <[email-masked]> (For isa)
> Acked-by: Stefan Richter <[email-masked]> (For firewire)
> Acked-by: Benjamin Tissoires <[email-masked]> (For hid)
> Acked-by: Thorsten Scherer <[email-masked]> (For siox)
> Acked-by: Sven Van Asbroeck <[email-masked]> (For anybuss)
> Acked-by: Ulf Hansson <[email-masked]> (For MMC)
> Signed-off-by: Uwe Kleine-König <[email-masked]>

Acked-by: Wolfram Sang <[email-masked]> # for I2C

Thanks, Uwe!