From: Heiko Carstens <hca@linux•ibm.com>
To: Arnd Bergmann <arnd@kernel•org>
Cc: Feng Tang <feng.tang@intel•com>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger•kernel.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership•com>,
Linux-MM <linux-mm@kvack•org>, Paul Mackerras <paulus@samba•org>,
"H. Peter Anvin" <hpa@zytor•com>,
sparclinux <sparclinux@vger•kernel.org>,
Will Deacon <will@kernel•org>, Christoph Hellwig <hch@lst•de>,
linux-arch <linux-arch@vger•kernel.org>,
linux-s390 <linux-s390@vger•kernel.org>,
Arnd Bergmann <arnd@arndb•de>, Helge Deller <deller@gmx•de>,
the arch/x86 maintainers <x86@kernel•org>,
Christoph Hellwig <hch@infradead•org>,
Christian Borntraeger <borntraeger@de•ibm.com>,
Ingo Molnar <mingo@redhat•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Vasily Gorbik <gor@linux•ibm.com>, Borislav Petkov <bp@alien8•de>,
Al Viro <viro@zeniv•linux.org.uk>,
Thomas Gleixner <tglx@linutronix•de>,
Linux ARM <linux-arm-kernel@lists•infradead.org>,
Thomas Bogendoerfer <tsbogend@alpha•franken.de>,
Parisc List <linux-parisc@vger•kernel.org>,
Linux API <linux-api@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
"Eric W. Biederman" <ebiederm@xmission•com>,
Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH v5 4/6] mm: simplify compat numa syscalls
Date: Tue, 27 Jul 2021 20:38:31 +0200 [thread overview]
Message-ID: <YQBSpxZR4P/Phpf1@osiris> (raw)
In-Reply-To: <CAK8P3a3itgCyc4jDBodTOcwG+XXsDYspZqQVBmy88cGXevY5Yw@mail.gmail.com>
On Tue, Jul 27, 2021 at 07:40:05PM +0200, Arnd Bergmann wrote:
> On Tue, Jul 27, 2021 at 7:27 PM Heiko Carstens <hca@linux•ibm.com> wrote:
> > > +static int get_bitmap(unsigned long *mask, const unsigned long __user *nmask,
> > > + unsigned long maxnode)
> > > +{
> > > + unsigned long nlongs = BITS_TO_LONGS(maxnode);
> > > + int ret;
> > > +
> > > + if (in_compat_syscall())
> > > + ret = compat_get_bitmap(mask,
> > > + (const compat_ulong_t __user *)nmask,
> > > + maxnode);
> >
> > compat_ptr() conversion for e.g. nmask is missing with the next patch
> > which removes the compat system calls.
> > Is that intended or am I missing something?
>
> I don't think it's needed here, since the pointer comes from the system
> call argument, which has the compat_ptr() conversion applied in
> arch/s390/include/asm/syscall_wrapper.h, not from a compat_uptr_t
> that gets passed indirectly. The compat_get_bitmap() conversion
> is only needed for byte order adjustment, not for converting pointers.
>
> It's also possible that I'm the one who's missing something.
What I was trying to say: this patch on its own is ok. However with
the next patch you remove the compat system calls and map the regular
system calls instead.
That is:
-COMPAT_SYSCALL_DEFINE6(mbind, compat_ulong_t, start, compat_ulong_t, len,
- compat_ulong_t, mode, compat_ulong_t __user *, nmask,
- compat_ulong_t, maxnode, compat_ulong_t, flags)
-{
- return kernel_mbind(start, len, mode, (unsigned long __user *)nmask,
- maxnode, flags);
-}
and this:
-268 common mbind sys_mbind compat_sys_mbind
-269 common get_mempolicy sys_get_mempolicy compat_sys_get_mempolicy
-270 common set_mempolicy sys_set_mempolicy compat_sys_set_mempolicy
+268 common mbind sys_mbind sys_mbind
+269 common get_mempolicy sys_get_mempolicy sys_get_mempolicy
+270 common set_mempolicy sys_set_mempolicy sys_set_mempolicy
would remove compat_ptr() conversion from nmask above if I'm not mistaken.
next prev parent reply other threads:[~2021-07-27 18:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 14:48 [PATCH v5 0/6] compat: remove compat_alloc_user_space Arnd Bergmann
2021-07-27 14:48 ` [PATCH v5 1/6] kexec: move locking into do_kexec_load Arnd Bergmann
2021-07-28 16:09 ` Eric W. Biederman
2021-07-27 14:48 ` [PATCH v5 2/6] kexec: avoid compat_alloc_user_space Arnd Bergmann
2021-07-28 16:10 ` Eric W. Biederman
2021-07-27 14:48 ` [PATCH v5 3/6] mm: simplify compat_sys_move_pages Arnd Bergmann
2021-07-27 14:48 ` [PATCH v5 4/6] mm: simplify compat numa syscalls Arnd Bergmann
2021-07-27 17:27 ` Heiko Carstens
2021-07-27 17:40 ` Arnd Bergmann
2021-07-27 18:38 ` Heiko Carstens [this message]
2021-07-27 18:49 ` Arnd Bergmann
2021-07-27 19:15 ` Heiko Carstens
2021-07-27 14:48 ` [PATCH v5 5/6] compat: remove some compat entry points Arnd Bergmann
2021-07-27 14:48 ` [PATCH v5 6/6] arch: remove compat_alloc_user_space Arnd Bergmann
2021-07-27 15:09 ` Christoph Hellwig
2021-07-27 14:59 ` [PATCH v5 0/6] compat: " Christoph Hellwig
2021-07-27 20:10 ` Andrew Morton
2021-07-27 20:42 ` Arnd Bergmann
2021-07-30 9:49 ` Heiko Carstens
2021-07-30 13:35 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQBSpxZR4P/Phpf1@osiris \
--to=hca@linux$(echo .)ibm.com \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=arnd@kernel$(echo .)org \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=ebiederm@xmission$(echo .)com \
--cc=feng.tang@intel$(echo .)com \
--cc=gor@linux$(echo .)ibm.com \
--cc=hch@infradead$(echo .)org \
--cc=hch@lst$(echo .)de \
--cc=hpa@zytor$(echo .)com \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox