From: Arnaldo Carvalho de Melo <acme@kernel•org>
To: Athira Rajeev <atrajeev@linux•vnet.ibm.com>
Cc: Madhavan Srinivasan <maddy@linux•ibm.com>,
rnsastry@linux•ibm.com, kajoljain <kjain@linux•ibm.com>,
Jiri Olsa <jolsa@kernel•org>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH 0/2] powerpc/perf: Add instruction and data address registers to extended regs
Date: Sat, 11 Sep 2021 16:09:24 -0300 [thread overview]
Message-ID: <YTz+5JxjH45ER5N1@kernel.org> (raw)
In-Reply-To: <BAA2B1EE-36BA-495A-B507-EC3C996199D8@linux.vnet.ibm.com>
Em Mon, Sep 06, 2021 at 08:13:13AM +0530, Athira Rajeev escreveu:
>
>
> > On 02-Sep-2021, at 1:04 PM, kajoljain <kjain@linux•ibm.com> wrote:
> >
> >
> >
> > On 6/20/21 8:15 PM, Athira Rajeev wrote:
> >> Patch set adds PMU registers namely Sampled Instruction Address Register
> >> (SIAR) and Sampled Data Address Register (SDAR) as part of extended regs
> >> in PowerPC. These registers provides the instruction/data address and
> >> adding these to extended regs helps in debug purposes.
> >>
> >> Patch 1/2 adds SIAR and SDAR as part of the extended regs mask.
> >> Patch 2/2 includes perf tools side changes to add the SPRs to
> >> sample_reg_mask to use with -I? option.
> >>
> >> Athira Rajeev (2):
> >> powerpc/perf: Expose instruction and data address registers as part of
> >> extended regs
> >> tools/perf: Add perf tools support to expose instruction and data
> >> address registers as part of extended regs
> >>
> >
> > Patchset looks good to me.
> >
> > Reviewed-By: kajol Jain<kjain@linux•ibm.com>
>
> Hi Arnaldo,
>
> Requesting for your review on this patchset.
So, this touches the kernel, usually I get a patchkit when the kernel
bits landed, is that the case by now?
- Arnaldo
>
> Thanks
> Athira
> >
> > Thanks,
> > Kajol Jain
> >
> >> arch/powerpc/include/uapi/asm/perf_regs.h | 12 +++++++-----
> >> arch/powerpc/perf/perf_regs.c | 4 ++++
> >> tools/arch/powerpc/include/uapi/asm/perf_regs.h | 12 +++++++-----
> >> tools/perf/arch/powerpc/include/perf_regs.h | 2 ++
> >> tools/perf/arch/powerpc/util/perf_regs.c | 2 ++
> >> 5 files changed, 22 insertions(+), 10 deletions(-)
--
- Arnaldo
next prev parent reply other threads:[~2021-09-11 19:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-20 14:45 [PATCH 0/2] powerpc/perf: Add instruction and data address registers to extended regs Athira Rajeev
2021-06-20 14:45 ` [PATCH 1/2] powerpc/perf: Expose instruction and data address registers as part of " Athira Rajeev
2021-09-08 5:17 ` Michael Ellerman
2021-09-09 2:48 ` Athira Rajeev
2021-09-20 7:13 ` Michael Ellerman
2021-09-21 3:01 ` Athira Rajeev
2021-06-20 14:46 ` [PATCH 2/2] tools/perf: Add perf tools support to expose " Athira Rajeev
2021-06-21 4:09 ` [PATCH 0/2] powerpc/perf: Add instruction and data address registers to " Nageswara Sastry
2021-09-02 7:34 ` kajoljain
2021-09-06 2:43 ` Athira Rajeev
2021-09-11 19:09 ` Arnaldo Carvalho de Melo [this message]
2021-09-20 6:54 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTz+5JxjH45ER5N1@kernel.org \
--to=acme@kernel$(echo .)org \
--cc=atrajeev@linux$(echo .)vnet.ibm.com \
--cc=jolsa@kernel$(echo .)org \
--cc=kjain@linux$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=rnsastry@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox