From: Sam Ravnborg <sam@ravnborg•org>
To: Arnd Bergmann <arnd@kernel•org>
Cc: linux-fbdev@vger•kernel.org, linux-parisc@vger•kernel.org,
Arnd Bergmann <arnd@arndb•de>, Helge Deller <deller@gmx•de>,
linux-kernel@vger•kernel.org, dri-devel@lists•freedesktop.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership•com>,
Paul Mackerras <paulus@samba•org>,
sparclinux@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH] agp: define proper stubs for empty helpers
Date: Mon, 20 Sep 2021 18:17:37 +0200 [thread overview]
Message-ID: <YUi0Ie66CDhqxgrn@ravnborg.org> (raw)
In-Reply-To: <20210920121728.94045-1-arnd@kernel.org>
On Mon, Sep 20, 2021 at 02:17:19PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb•de>
>
> The empty unmap_page_from_agp() macro causes a warning when
> building with 'make W=1' on a couple of architectures:
>
> drivers/char/agp/generic.c: In function 'agp_generic_destroy_page':
> drivers/char/agp/generic.c:1265:28: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 1265 | unmap_page_from_agp(page);
>
> Change the definitions to a 'do { } while (0)' construct to
> make these more reliable.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
Looks good.
Acked-by: Sam Ravnborg <sam@ravnborg•org>
Sam
next prev parent reply other threads:[~2021-09-20 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:17 [PATCH] agp: define proper stubs for empty helpers Arnd Bergmann
2021-09-20 16:17 ` Sam Ravnborg [this message]
2021-09-20 18:01 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUi0Ie66CDhqxgrn@ravnborg.org \
--to=sam@ravnborg$(echo .)org \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=arnd@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=linux-fbdev@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox