From: Mike Rapoport <rppt@kernel•org>
To: Rob Herring <robh@kernel•org>
Cc: "Kirill A. Shutemov" <kirill.shtuemov@linux•intel.com>,
Mark Rutland <mark.rutland@arm•com>,
Kefeng Wang <wangkefeng.wang@huawei•com>,
Rich Felker <dalias@libc•org>, Jinyang He <hejinyang@loongson•cn>,
David Hildenbrand <david@redhat•com>,
Lee Jones <lee.jones@linaro•org>,
linux-kernel@vger•kernel.org, Max Filippov <jcmvbkbc@gmail•com>,
Anup Patel <anup.patel@wdc•com>,
Guo Ren <guoren@linux•alibaba.com>, Guo Ren <guoren@kernel•org>,
Calvin Zhang <calvinzhang.cool@gmail•com>,
Nick Kossifidis <mick@ics•forth.gr>,
Vladimir Isaev <isaev@synopsys•com>,
Tiezhu Yang <yangtiezhu@loongson•cn>,
Vincent Chen <deanbo422@gmail•com>, Will Deacon <will@kernel•org>,
Markus Elfring <elfring@users•sourceforge.net>,
Vitaly Wool <vitaly.wool@konsulko•com>,
Jonas Bonn <jonas@southpole•se>,
devicetree@vger•kernel.org, linux-snps-arc@lists•infradead.org,
uclinux-h8-devel@lists•sourceforge.jp,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Palmer Dabbelt <palmerdabbelt@google•com>,
linux-sh@vger•kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel•com>,
Russell King <linux@armlinux•org.uk>,
Ley Foon Tan <ley.foon.tan@intel•com>,
Geert Uytterhoeven <geert@linux-m68k•org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux•ibm.com>,
Catalin Marinas <catalin.marinas@arm•com>,
Ganesh Goudar <ganeshgr@linux•ibm.com>,
David Brazdil <dbrazdil@google•com>,
linux-riscv@lists•infradead.org,
Guenter Roeck <linux@roeck-us•net>,
Alexander Sverdlin <alexander.sverdlin@nokia•com>,
Thierry Reding <treding@nvidia•com>,
Albert Ou <aou@eecs•berkeley.edu>, Arnd Bergmann <arnd@arndb•de>,
Anshuman Khandual <anshuman.khandual@arm•com>,
linux-xtensa@linux-xtensa•org, Vineet Gupta <vgupta@kernel•org>,
Andreas Oetken <andreas.oetken@siemens•com>,
Stefan Kristiansson <stefan.kristiansson@saunalahti•fi>,
"Russell King \(Oracle\)" <rmk+kernel@armlinux•org.uk>,
linux-csky@vger•kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo•fr>,
Greentime Hu <green.hu@gmail•com>,
Paul Walmsley <paul.walmsley@sifive•com>,
Stafford Horne <shorne@gmail•com>,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
linux-arm-kernel@lists•infradead.org,
Andrey Konovalov <andreyknvl@gmail•com>,
Christophe Leroy <christophe.leroy@c-s•fr>,
Chris Zankel <chris@zankel•net>,
Thomas Bogendoerfer <tsbogend@alpha•franken.de>,
linux-mips@vger•kernel.org, Alexandre Ghiti <alex@ghiti•fr>,
Nick Hu <nickhu@andestech•com>, Atish Patra <atish.patra@wdc•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Randy Dunlap <rdunlap@infradead•org>,
Frank Rowand <frowand.list@gmail•com>,
Serge Semin <Sergey.Semin@baikalelectronics•ru>,
Dinh Nguyen <dinguyen@kernel•org>,
Zhang Yunkai <zhang.yunkai@zte•com.cn>,
Palmer Dabbelt <palmer@dabbelt•com>,
Souptick Joarder <jrdr.linux@gmail•com>,
Marc Zyngier <maz@kernel•org>,
Mauri Sandberg <sandberg@mailfence•com>,
Paul Mackerras <paulus@samba•org>,
Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org, openrisc@lists•librecores.org
Subject: Re: [PATCH 0/2] of: remove reserved regions count restriction
Date: Tue, 30 Nov 2021 23:07:40 +0200 [thread overview]
Message-ID: <YaaSnJ2Meo5mEKDN@kernel.org> (raw)
In-Reply-To: <YaVrahm+ysoQRGKe@robh.at.kernel.org>
On Mon, Nov 29, 2021 at 06:08:10PM -0600, Rob Herring wrote:
> On Sun, Nov 21, 2021 at 08:43:47AM +0200, Mike Rapoport wrote:
> > On Fri, Nov 19, 2021 at 03:58:17PM +0800, Calvin Zhang wrote:
> > > The count of reserved regions in /reserved-memory was limited because
> > > the struct reserved_mem array was defined statically. This series sorts
> > > out reserved memory code and allocates that array from early allocator.
> > >
> > > Note: reserved region with fixed location must be reserved before any
> > > memory allocation. While struct reserved_mem array should be allocated
> > > after allocator is activated. We make early_init_fdt_scan_reserved_mem()
> > > do reservation only and add another call to initialize reserved memory.
> > > So arch code have to change for it.
> >
> > I think much simpler would be to use the same constant for sizing
> > memblock.reserved and reserved_mem arrays.
>
> Do those arrays get shrunk? Or do we waste the memory forever?
Memblock arrays don't get shrunk, but they are __init unless an architecture
chose to keep them after boot, but most architectures that use device tree
actually keep memblock structures.
> Maybe we can copy and shrink the initial array? Though I suspect struct
> reserved_mem pointers have already been given out.
I'm not sure. It seems that reserved_mem pointers are given out at initcall
time and AFAIU the reserved_mem array is created somewhere around
setup_arch(). So maybe it's possible to copy and shrink the initial array.
> >
> > If there is too much reserved regions in the device tree, reserving them in
> > memblock will fail anyway because memblock also starts with static array
> > for memblock.reserved, so doing one pass with memblock_reserve() and
> > another to set up reserved_mem wouldn't help anyway.
> >
> > > I'm only familiar with arm and arm64 architectures. Approvals from arch
> > > maintainers are required. Thank you all.
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2021-11-30 22:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 7:58 [PATCH 0/2] of: remove reserved regions count restriction Calvin Zhang
2021-11-19 7:58 ` [PATCH 1/2] of: Sort reserved_mem related code Calvin Zhang
2021-11-30 0:01 ` Rob Herring
2021-11-19 7:58 ` [PATCH 2/2] of: reserved_mem: Remove reserved regions count restriction Calvin Zhang
2021-11-19 9:56 ` Andy Shevchenko
2021-11-19 10:27 ` Calvin Zhang
2021-11-19 10:30 ` Calvin Zhang
2021-11-21 6:43 ` [PATCH 0/2] of: remove " Mike Rapoport
2021-11-21 9:01 ` Calvin Zhang
2021-11-30 0:08 ` Rob Herring
2021-11-30 21:07 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaaSnJ2Meo5mEKDN@kernel.org \
--to=rppt@kernel$(echo .)org \
--cc=Sergey.Semin@baikalelectronics$(echo .)ru \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alex@ghiti$(echo .)fr \
--cc=alexander.sverdlin@nokia$(echo .)com \
--cc=andreas.oetken@siemens$(echo .)com \
--cc=andreyknvl@gmail$(echo .)com \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=aneesh.kumar@linux$(echo .)ibm.com \
--cc=anshuman.khandual@arm$(echo .)com \
--cc=anup.patel@wdc$(echo .)com \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=arnd@arndb$(echo .)de \
--cc=atish.patra@wdc$(echo .)com \
--cc=calvinzhang.cool@gmail$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chris@zankel$(echo .)net \
--cc=christophe.jaillet@wanadoo$(echo .)fr \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=dalias@libc$(echo .)org \
--cc=david@redhat$(echo .)com \
--cc=dbrazdil@google$(echo .)com \
--cc=deanbo422@gmail$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dinguyen@kernel$(echo .)org \
--cc=elfring@users$(echo .)sourceforge.net \
--cc=frowand.list@gmail$(echo .)com \
--cc=ganeshgr@linux$(echo .)ibm.com \
--cc=geert@linux-m68k$(echo .)org \
--cc=green.hu@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=guoren@kernel$(echo .)org \
--cc=guoren@linux$(echo .)alibaba.com \
--cc=hejinyang@loongson$(echo .)cn \
--cc=isaev@synopsys$(echo .)com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=jonas@southpole$(echo .)se \
--cc=jrdr.linux@gmail$(echo .)com \
--cc=kirill.shtuemov@linux$(echo .)intel.com \
--cc=lee.jones@linaro$(echo .)org \
--cc=ley.foon.tan@intel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-csky@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linux@roeck-us$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=maz@kernel$(echo .)org \
--cc=mick@ics$(echo .)forth.gr \
--cc=nickhu@andestech$(echo .)com \
--cc=openrisc@lists$(echo .)librecores.org \
--cc=palmer@dabbelt$(echo .)com \
--cc=palmerdabbelt@google$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
--cc=robh@kernel$(echo .)org \
--cc=sandberg@mailfence$(echo .)com \
--cc=shorne@gmail$(echo .)com \
--cc=stefan.kristiansson@saunalahti$(echo .)fi \
--cc=treding@nvidia$(echo .)com \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=uclinux-h8-devel@lists$(echo .)sourceforge.jp \
--cc=vgupta@kernel$(echo .)org \
--cc=vitaly.wool@konsulko$(echo .)com \
--cc=wangkefeng.wang@huawei$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=yangtiezhu@loongson$(echo .)cn \
--cc=ysato@users$(echo .)sourceforge.jp \
--cc=zhang.yunkai@zte$(echo .)com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox