From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: Yury Norov <yury.norov@gmail•com>
Cc: "Juri Lelli" <juri.lelli@redhat•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Rafael J. Wysocki" <rafael@kernel•org>,
"Catalin Marinas" <catalin.marinas@arm•com>,
"Guo Ren" <guoren@kernel•org>, "Christoph Lameter" <cl@linux•com>,
"Christoph Hellwig" <hch@lst•de>,
"Andi Kleen" <ak@linux•intel.com>,
"Vincent Guittot" <vincent.guittot@linaro•org>,
"Ingo Molnar" <mingo@redhat•com>,
"Geert Uytterhoeven" <geert@linux-m68k•org>,
"Mel Gorman" <mgorman@suse•de>,
"Viresh Kumar" <viresh.kumar@linaro•org>,
"Petr Mladek" <pmladek@suse•com>,
"Arnaldo Carvalho de Melo" <acme@kernel•org>,
"Michał Mirosław" <mirq-linux@rere•qmqm.pl>,
"Jens Axboe" <axboe@fb•com>, "Andy Lutomirski" <luto@kernel•org>,
"Lee Jones" <lee.jones@linaro•org>,
"Randy Dunlap" <rdunlap@infradead•org>,
linux-kernel@vger•kernel.org, linux-perf-users@vger•kernel.org,
"Sergey Senozhatsky" <senozhatsky@chromium•org>,
"Thomas Gleixner" <tglx@linutronix•de>,
linux-crypto@vger•kernel.org, "Joe Perches" <joe@perches•com>,
"Andrew Morton" <akpm@linux-foundation•org>,
"Mark Rutland" <mark.rutland@arm•com>,
"Anup Patel" <anup.patel@wdc•com>,
linux-ia64@vger•kernel.org, "David Airlie" <airlied@linux•ie>,
"Dave Hansen" <dave.hansen@linux•intel.com>,
"Solomon Peachy" <pizza@shaftnet•org>,
"Stephen Rothwell" <sfr@canb•auug.org.au>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical•com>,
"Dennis Zhou" <dennis@kernel•org>,
"Matti Vaittinen" <mazziesaccount@gmail•com>,
"Sudeep Holla" <sudeep.holla@arm•com>,
"Tejun Heo" <tj@kernel•org>,
linux-arm-kernel@lists•infradead.org,
"Stephen Boyd" <sboyd@kernel•org>,
"Tariq Toukan" <tariqt@nvidia•com>,
"Jonathan Cameron" <jic23@kernel•org>,
"Ulf Hansson" <ulf.hansson@linaro•org>,
"Emil Renner Berthing" <kernel@esmil•dk>,
"Alexander Shishkin" <alexander.shishkin@linux•intel.com>,
"Mike Marciniszyn" <mike.marciniszyn@cornelisnetworks•com>,
"Rasmus Villemoes" <linux@rasmusvillemoes•dk>,
"Subbaraya Sundeep" <sbhatta@marvell•com>,
"Will Deacon" <will@kernel•org>,
"Sagi Grimberg" <sagi@grimberg•me>,
linux-csky@vger•kernel.org,
bcm-kernel-feedback-list@broadcom•com,
linux-snps-arc@lists•infradead.org,
"Kees Cook" <keescook@chromium•org>,
"Arnd Bergmann" <arnd@arndb•de>,
"James E.J. Bottomley" <jejb@linux•ibm.com>,
"Vineet Gupta" <vgupta@kernel•org>,
"Steven Rostedt" <rostedt@goodmis•org>,
"Mark Gross" <markgross@kernel•org>,
"Borislav Petkov" <bp@alien8•de>,
"Mauro Carvalho Chehab" <mchehab@kernel•org>,
"Thomas Bogendoerfer" <tsbogend@alpha•franken.de>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
"David Laight" <David.Laight@aculab•com>,
linux-alpha@vger•kernel.org,
"Geetha sowjanya" <gakula@marvell•com>,
"Ian Rogers" <irogers@google•com>,
kvm@vger•kernel.org, "Peter Zijlstra" <peterz@infradead•org>,
"Amitkumar Karwar" <amitkarwar@gmail•com>,
linux-mm@kvack•org, linux-riscv@lists•infradead.org,
"Jiri Olsa" <jolsa@redhat•com>,
"Ard Biesheuvel" <ardb@kernel•org>,
"Marc Zyngier" <maz@kernel•org>,
"Russell King" <linux@armlinux•org.uk>,
"Andy Gross" <agross@kernel•org>,
"Jakub Kicinski" <kuba@kernel•org>,
"Vivien Didelot" <vivien.didelot@gmail•com>,
"Sunil Goutham" <sgoutham@marvell•com>,
"Paul E. McKenney" <paulmck@kernel•org>,
linux-s390@vger•kernel.org, "Alexey Klimov" <aklimov@redhat•com>,
"Heiko Carstens" <hca@linux•ibm.com>,
"Hans de Goede" <hdegoede@redhat•com>,
"Nicholas Piggin" <npiggin@gmail•com>,
"Marcin Wojtas" <mw@semihalf•com>,
"Vlastimil Babka" <vbabka@suse•cz>,
linuxppc-dev@lists•ozlabs.org, linux-mips@vger•kernel.org,
"Palmer Dabbelt" <palmer@dabbelt•com>,
"Daniel Vetter" <daniel@ffwll•ch>,
"Jason Wessel" <jason.wessel@windriver•com>,
"Saeed Mahameed" <saeedm@nvidia•com>,
"Andy Shevchenko" <andy@infradead•org>
Subject: Re: [PATCH 08/17] all: replace bitmap_weight with bitmap_weight_{eq,gt,ge,lt,le} where appropriate
Date: Mon, 20 Dec 2021 17:41:02 +0100 [thread overview]
Message-ID: <YcCyHvr1f+Z8M9M1@kroah.com> (raw)
In-Reply-To: <20211218212014.1315894-9-yury.norov@gmail.com>
On Sat, Dec 18, 2021 at 01:20:04PM -0800, Yury Norov wrote:
> Kernel code calls bitmap_weight() to compare the weight of bitmap with
> a given number. We can do it more efficiently with bitmap_weight_{eq, ...}
> because conditional bitmap_weight may stop traversing the bitmap earlier,
> as soon as condition is met.
>
> This patch replaces bitmap_weight with conditional versions where possible,
> except for small bitmaps which size is not configurable and known at
> constant time. In that case conditional version of bitmap_weight would not
> benefit due to small_const_nbits() optimization; but readability may
> suffer.
>
> Signed-off-by: Yury Norov <yury.norov@gmail•com>
> ---
> arch/x86/kernel/cpu/resctrl/rdtgroup.c | 2 +-
> drivers/iio/dummy/iio_simple_dummy_buffer.c | 4 ++--
> drivers/iio/industrialio-trigger.c | 2 +-
> drivers/memstick/core/ms_block.c | 4 ++--
> drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +-
> .../net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 2 +-
> .../net/ethernet/marvell/octeontx2/nic/otx2_flows.c | 4 ++--
> drivers/net/ethernet/mellanox/mlx4/cmd.c | 10 +++-------
> drivers/net/ethernet/mellanox/mlx4/eq.c | 4 ++--
> drivers/net/ethernet/mellanox/mlx4/fw.c | 4 ++--
> drivers/net/ethernet/mellanox/mlx4/main.c | 2 +-
> drivers/perf/thunderx2_pmu.c | 4 ++--
> drivers/staging/media/tegra-video/vi.c | 2 +-
> 13 files changed, 21 insertions(+), 25 deletions(-)
"all" is not how to submit changes to the kernel. Please break them up
into subsystem-specific patches, and send them after your core changes
are accepted.
good luck!
greg k-h
next prev parent reply other threads:[~2021-12-20 20:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 21:19 [PATCH v2 00/17] lib/bitmap: optimize bitmap_weight() usage Yury Norov
2021-12-18 21:19 ` [PATCH 01/17] all: don't use bitmap_weight() where possible Yury Norov
2021-12-18 22:15 ` Michał Mirosław
2021-12-18 23:28 ` Yury Norov
2021-12-18 21:19 ` [PATCH 02/17] drivers: rename num_*_cpus variables Yury Norov
2021-12-18 21:19 ` [PATCH 03/17] fix open-coded for_each_set_bit() Yury Norov
2021-12-18 21:20 ` [PATCH 04/17] all: replace bitmap_weight with bitmap_empty where appropriate Yury Norov
2021-12-18 21:20 ` [PATCH 05/17] all: replace cpumask_weight with cpumask_empty " Yury Norov
2021-12-18 21:20 ` [PATCH 06/17] all: replace nodes_weight with nodes_empty " Yury Norov
2021-12-18 21:20 ` [PATCH 07/17] lib/bitmap: add bitmap_weight_{cmp, eq, gt, ge, lt, le} functions Yury Norov
2021-12-18 21:20 ` [PATCH 08/17] all: replace bitmap_weight with bitmap_weight_{eq, gt, ge, lt, le} where appropriate Yury Norov
2021-12-20 16:41 ` Greg Kroah-Hartman [this message]
2021-12-18 21:20 ` [PATCH 09/17] lib/cpumask: add cpumask_weight_{eq,gt,ge,lt,le} Yury Norov
2021-12-18 21:20 ` [PATCH 10/17] lib/nodemask: add nodemask_weight_{eq,gt,ge,lt,le} Yury Norov
2021-12-18 21:20 ` [PATCH 11/17] lib/nodemask: add num_node_state_eq() Yury Norov
2021-12-18 21:20 ` [PATCH 12/17] kernel/cpu.c: fix init_cpu_online Yury Norov
2021-12-18 21:20 ` [PATCH 13/17] kernel/cpu: add num_possible_cpus counter Yury Norov
2021-12-21 13:15 ` Peter Zijlstra
2021-12-18 21:20 ` [PATCH 14/17] kernel/cpu: add num_present_cpu counter Yury Norov
2021-12-21 13:14 ` Peter Zijlstra
2021-12-18 21:20 ` [PATCH 15/17] kernel/cpu: add num_active_cpu counter Yury Norov
2021-12-21 13:13 ` Peter Zijlstra
2021-12-18 21:20 ` [PATCH 16/17] tools/bitmap: sync bitmap_weight Yury Norov
2021-12-18 21:20 ` [PATCH 17/17] MAINTAINERS: add cpumask and nodemask files to BITMAP_API Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcCyHvr1f+Z8M9M1@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=David.Laight@aculab$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=agross@kernel$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=ak@linux$(echo .)intel.com \
--cc=aklimov@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=amitkarwar@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=andy@infradead$(echo .)org \
--cc=anup.patel@wdc$(echo .)com \
--cc=ardb@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=axboe@fb$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=cl@linux$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=dennis@kernel$(echo .)org \
--cc=gakula@marvell$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=guoren@kernel$(echo .)org \
--cc=hca@linux$(echo .)ibm.com \
--cc=hch@lst$(echo .)de \
--cc=hdegoede@redhat$(echo .)com \
--cc=irogers@google$(echo .)com \
--cc=jason.wessel@windriver$(echo .)com \
--cc=jejb@linux$(echo .)ibm.com \
--cc=jic23@kernel$(echo .)org \
--cc=joe@perches$(echo .)com \
--cc=jolsa@redhat$(echo .)com \
--cc=juri.lelli@redhat$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kernel@esmil$(echo .)dk \
--cc=krzysztof.kozlowski@canonical$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=lee.jones@linaro$(echo .)org \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-csky@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linux@rasmusvillemoes$(echo .)dk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=luto@kernel$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=markgross@kernel$(echo .)org \
--cc=martin.petersen@oracle$(echo .)com \
--cc=maz@kernel$(echo .)org \
--cc=mazziesaccount@gmail$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=mgorman@suse$(echo .)de \
--cc=mike.marciniszyn@cornelisnetworks$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=mirq-linux@rere$(echo .)qmqm.pl \
--cc=mw@semihalf$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paulmck@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=pizza@shaftnet$(echo .)org \
--cc=pmladek@suse$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=rdunlap@infradead$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=saeedm@nvidia$(echo .)com \
--cc=sagi@grimberg$(echo .)me \
--cc=sbhatta@marvell$(echo .)com \
--cc=sboyd@kernel$(echo .)org \
--cc=senozhatsky@chromium$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=sgoutham@marvell$(echo .)com \
--cc=sudeep.holla@arm$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tj@kernel$(echo .)org \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=vbabka@suse$(echo .)cz \
--cc=vgupta@kernel$(echo .)org \
--cc=vincent.guittot@linaro$(echo .)org \
--cc=viresh.kumar@linaro$(echo .)org \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=yury.norov@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox