* [PATCH] powerpc/64e: Rewrite p4d_populate() as a static inline function
@ 2022-06-23 8:56 Christophe Leroy
2022-06-23 17:13 ` Mike Rapoport
2022-07-04 11:33 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Christophe Leroy @ 2022-06-23 8:56 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
Cc: Mike Rapoport, linuxppc-dev, linux-kernel
Rewrite p4d_populate() as a static inline function instead of
a macro.
This change allows typechecking and would have helped detecting
a recently found bug in map_kernel_page().
Cc: Mike Rapoport <rppt@kernel•org>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup•eu>
---
arch/powerpc/include/asm/nohash/64/pgalloc.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/nohash/64/pgalloc.h b/arch/powerpc/include/asm/nohash/64/pgalloc.h
index 668aee6017e7..e50b211becb3 100644
--- a/arch/powerpc/include/asm/nohash/64/pgalloc.h
+++ b/arch/powerpc/include/asm/nohash/64/pgalloc.h
@@ -15,7 +15,10 @@ struct vmemmap_backing {
};
extern struct vmemmap_backing *vmemmap_list;
-#define p4d_populate(MM, P4D, PUD) p4d_set(P4D, (unsigned long)PUD)
+static inline void p4d_populate(struct mm_struct *mm, p4d_t *p4d, pud_t *pud)
+{
+ p4d_set(p4d, (unsigned long)pud);
+}
static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long addr)
{
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/64e: Rewrite p4d_populate() as a static inline function
2022-06-23 8:56 [PATCH] powerpc/64e: Rewrite p4d_populate() as a static inline function Christophe Leroy
@ 2022-06-23 17:13 ` Mike Rapoport
2022-07-04 11:33 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2022-06-23 17:13 UTC (permalink / raw)
To: Christophe Leroy; +Cc: linuxppc-dev, Paul Mackerras, linux-kernel
On Thu, Jun 23, 2022 at 10:56:57AM +0200, Christophe Leroy wrote:
> Rewrite p4d_populate() as a static inline function instead of
> a macro.
>
> This change allows typechecking and would have helped detecting
> a recently found bug in map_kernel_page().
>
> Cc: Mike Rapoport <rppt@kernel•org>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup•eu>
Acked-by: Mike Rapoport <rppt@linux•ibm.com>
> ---
> arch/powerpc/include/asm/nohash/64/pgalloc.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/nohash/64/pgalloc.h b/arch/powerpc/include/asm/nohash/64/pgalloc.h
> index 668aee6017e7..e50b211becb3 100644
> --- a/arch/powerpc/include/asm/nohash/64/pgalloc.h
> +++ b/arch/powerpc/include/asm/nohash/64/pgalloc.h
> @@ -15,7 +15,10 @@ struct vmemmap_backing {
> };
> extern struct vmemmap_backing *vmemmap_list;
>
> -#define p4d_populate(MM, P4D, PUD) p4d_set(P4D, (unsigned long)PUD)
> +static inline void p4d_populate(struct mm_struct *mm, p4d_t *p4d, pud_t *pud)
> +{
> + p4d_set(p4d, (unsigned long)pud);
> +}
>
> static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long addr)
> {
> --
> 2.36.1
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/64e: Rewrite p4d_populate() as a static inline function
2022-06-23 8:56 [PATCH] powerpc/64e: Rewrite p4d_populate() as a static inline function Christophe Leroy
2022-06-23 17:13 ` Mike Rapoport
@ 2022-07-04 11:33 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2022-07-04 11:33 UTC (permalink / raw)
To: Christophe Leroy, Paul Mackerras, Michael Ellerman,
Benjamin Herrenschmidt
Cc: linuxppc-dev, linux-kernel, Mike Rapoport
On Thu, 23 Jun 2022 10:56:57 +0200, Christophe Leroy wrote:
> Rewrite p4d_populate() as a static inline function instead of
> a macro.
>
> This change allows typechecking and would have helped detecting
> a recently found bug in map_kernel_page().
>
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/64e: Rewrite p4d_populate() as a static inline function
https://git.kernel.org/powerpc/c/2db2008e636327a3caa648ef1e34a9d501d20e2e
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-04 11:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-23 8:56 [PATCH] powerpc/64e: Rewrite p4d_populate() as a static inline function Christophe Leroy
2022-06-23 17:13 ` Mike Rapoport
2022-07-04 11:33 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox