From: "Jason A. Donenfeld" <Jason@zx2c4•com>
To: Michael Ellerman <michael@ellerman•id.au>
Cc: stable@vger•kernel.org, paulus@samba•org,
linuxppc-dev@lists•ozlabs.org,
Sachin Sant <sachinp@linux•ibm.com>
Subject: Re: [PATCH] powerpc/powernv: delay rng of node creation until later in boot
Date: Mon, 4 Jul 2022 13:34:22 +0200 [thread overview]
Message-ID: <YsLQPpAY6ZZHCOAI@zx2c4.com> (raw)
In-Reply-To: <2B9FC5ED-D6B8-4632-ACA4-7CF508EE9C46@ellerman.id.au>
Hi Michael,
On Mon, Jul 04, 2022 at 09:14:32PM +1000, Michael Ellerman wrote:
>
>
> On 2 July 2022 8:42:06 pm AEST, "Jason A. Donenfeld" <Jason@zx2c4•com> wrote:
> >Hi Benjamin, Paul,
> >
> >On Thu, Jun 30, 2022 at 07:24:05PM +0530, Sachin Sant wrote:
> >> > On 30-Jun-2022, at 5:46 PM, Jason A. Donenfeld <Jason@zx2c4•com> wrote:
> >> >
> >> > The of node for the rng must be created much later in boot. Otherwise it
> >> > tries to connect to a parent that doesn't yet exist, resulting on this
> >> > splat:
> >> >
> >> > [ 0.000478] kobject: '(null)' ((____ptrval____)): is not initialized, yet kobject_get() is being called.
> >> > [ 0.002925] [c000000002a0fb30] [c00000000073b0bc] kobject_get+0x8c/0x100 (unreliable)
> >> > [ 0.003071] [c000000002a0fba0] [c00000000087e464] device_add+0xf4/0xb00
> >> > [ 0.003194] [c000000002a0fc80] [c000000000a7f6e4] of_device_add+0x64/0x80
> >> > [ 0.003321] [c000000002a0fcb0] [c000000000a800d0] of_platform_device_create_pdata+0xd0/0x1b0
> >> > [ 0.003476] [c000000002a0fd00] [c00000000201fa44] pnv_get_random_long_early+0x240/0x2e4
> >> > [ 0.003623] [c000000002a0fe20] [c000000002060c38] random_init+0xc0/0x214
> >> >
> >> > This patch fixes the issue by doing the of node creation inside of
> >> > machine_subsys_initcall.
> >> >
> >> > Fixes: f3eac426657d ("powerpc/powernv: wire up rng during setup_arch")
> >> > Cc: stable@vger•kernel.org
> >> > Cc: Michael Ellerman <mpe@ellerman•id.au>
> >> > Reported-by: Sachin Sant <sachinp@linux•ibm.com>
> >> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4•com>
> >> > ---
> >>
> >> Thanks Jason for the patch. This fixes the reported problem for me.
> >>
> >> Tested-by: Sachin Sant <sachinp@linux•ibm.com>
> >>
> >> - Sachin
> >
> >It sounds like Michael is on vacation for a few weeks. Think you could
> >queue this up so we can get POWER8 booting again?
>
> It doesn't break booting for me, but it is an ugly splat.
>
> I'll pick it up into fixes.
>
> I think it's more correct to say the "platform device creation" causes the problem, so I'll update the change log to say that.
Sounds good. Thank you!
Jason
next prev parent reply other threads:[~2022-07-04 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 11:31 [next-20220629] kobject warnings during boot Sachin Sant
2022-06-30 11:55 ` Jason A. Donenfeld
2022-06-30 12:16 ` [PATCH] powerpc/powernv: delay rng of node creation until later in boot Jason A. Donenfeld
2022-06-30 13:54 ` Sachin Sant
2022-07-02 10:42 ` Jason A. Donenfeld
2022-07-04 11:14 ` Michael Ellerman
2022-07-04 11:34 ` Jason A. Donenfeld [this message]
2022-07-04 11:57 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsLQPpAY6ZZHCOAI@zx2c4.com \
--to=jason@zx2c4$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=michael@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=sachinp@linux$(echo .)ibm.com \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox