From: Peter Zijlstra <peterz@infradead•org>
To: Christophe Leroy <christophe.leroy@csgroup•eu>
Cc: "aik@ozlabs•ru" <aik@ozlabs•ru>,
"chenzhongjin@huawei•com" <chenzhongjin@huawei•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"rostedt@goodmis•org" <rostedt@goodmis•org>,
"mingo@redhat•com" <mingo@redhat•com>,
Sathvika Vasireddy <sv@linux•ibm.com>,
"npiggin@gmail•com" <npiggin@gmail•com>,
"jpoimboe@redhat•com" <jpoimboe@redhat•com>,
"naveen.n.rao@linux•vnet.ibm.com"
<naveen.n.rao@linux•vnet.ibm.com>,
"mbenes@suse•cz" <mbenes@suse•cz>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH v2 08/16] objtool: Fix SEGFAULT
Date: Fri, 2 Sep 2022 10:42:17 +0200 [thread overview]
Message-ID: <YxHB6VzfXYozAPEA@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <66a3976b-48c1-f8c4-aee0-d04c2c11f5af@csgroup.eu>
On Fri, Sep 02, 2022 at 08:06:28AM +0000, Christophe Leroy wrote:
>
>
> Le 01/09/2022 à 21:20, Peter Zijlstra a écrit :
> > On Mon, Aug 29, 2022 at 11:22:15AM +0530, Sathvika Vasireddy wrote:
> >> From: Christophe Leroy <christophe.leroy@csgroup•eu>
> >>
> >> find_insn() will return NULL in case of failure. Check insn in order
> >> to avoid a kernel Oops for NULL pointer dereference.
> >>
> >> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup•eu>
> >> ---
> >> tools/objtool/check.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> >> index 91678252a9b6..ed2fdfeb1d9c 100644
> >> --- a/tools/objtool/check.c
> >> +++ b/tools/objtool/check.c
> >> @@ -205,7 +205,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
> >> return false;
> >>
> >> insn = find_insn(file, func->sec, func->offset);
> >> - if (!insn->func)
> >> + if (!insn || !insn->func)
> >> return false;
> >
> > I suppose this is ok, but how can the lookup for func->sec, func->offset
> > *not* find an instruction ?!
>
> That happened to me at the begining when the port to powerpc was not
> fully functionnal.
>
> I guess that could also happen with a corrupted object file so better
> safe than sorry.
Fair enough.
Acked-by: Peter Zijlstra (Intel) <peterz@infradead•org>
next prev parent reply other threads:[~2022-09-02 8:43 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 5:52 [PATCH v2 00/16] objtool: Enable and implement --mcount option on powerpc Sathvika Vasireddy
2022-08-29 5:52 ` [PATCH v2 01/16] powerpc: Replace unreachable() with it's builtin variant in __WARN_FLAGS() Sathvika Vasireddy
2022-08-30 6:15 ` Christophe Leroy
2022-09-05 10:18 ` Naveen N. Rao
2022-08-29 5:52 ` [PATCH v2 02/16] powerpc: override __ALIGN() and __ALIGN_STR() macros Sathvika Vasireddy
2022-08-29 13:26 ` Christophe Leroy
2022-08-29 14:39 ` Sathvika Vasireddy
2022-08-31 3:24 ` Nicholas Piggin
2022-08-31 7:22 ` Michael Ellerman
2022-09-05 11:03 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 03/16] powerpc: Fix objtool unannotated intra-function call warnings Sathvika Vasireddy
2022-08-30 6:16 ` Christophe Leroy
2022-08-30 12:42 ` Christophe Leroy
2022-09-05 11:02 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 04/16] powerpc: Curb objtool unannotated intra-function warnings Sathvika Vasireddy
2022-08-30 6:26 ` Christophe Leroy
2022-08-29 5:52 ` [PATCH v2 05/16] powerpc: Skip objtool from running on drivers/crypto/vmx/aesp8-ppc.o Sathvika Vasireddy
2022-08-30 6:26 ` Christophe Leroy
2022-09-01 19:17 ` Peter Zijlstra
2022-09-05 10:47 ` Naveen N. Rao
2022-08-29 5:52 ` [PATCH v2 06/16] powerpc: Fix objtool unannotated intra-function call warnings on PPC32 Sathvika Vasireddy
2022-08-29 5:52 ` [PATCH v2 07/16] powerpc: Skip objtool from running on VDSO files Sathvika Vasireddy
2022-08-30 6:27 ` Christophe Leroy
2022-09-01 19:19 ` Peter Zijlstra
2022-09-02 7:40 ` Michael Ellerman
2022-08-29 5:52 ` [PATCH v2 08/16] objtool: Fix SEGFAULT Sathvika Vasireddy
2022-09-01 19:20 ` Peter Zijlstra
2022-09-02 8:06 ` Christophe Leroy
2022-09-02 8:42 ` Peter Zijlstra [this message]
2022-08-29 5:52 ` [PATCH v2 09/16] objtool: Use target file endianness instead of a compiled constant Sathvika Vasireddy
2022-09-01 19:22 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 10/16] objtool: Use target file class size " Sathvika Vasireddy
2022-09-01 19:23 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 11/16] objtool: Add --mnop as an option to --mcount Sathvika Vasireddy
2022-08-30 6:28 ` Christophe Leroy
2022-09-01 19:25 ` Peter Zijlstra
2022-09-05 10:55 ` Naveen N. Rao
2022-08-29 5:52 ` [PATCH v2 12/16] objtool: Read special sections with alts only when specific options are selected Sathvika Vasireddy
2022-08-30 6:31 ` Christophe Leroy
2022-08-29 5:52 ` [PATCH v2 13/16] objtool: Use macros to define arch specific reloc types Sathvika Vasireddy
2022-08-30 6:33 ` Christophe Leroy
2022-09-01 19:28 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 14/16] objtool: Add arch specific function arch_ftrace_match() Sathvika Vasireddy
2022-08-30 6:36 ` Christophe Leroy
2022-08-29 5:52 ` [PATCH v2 15/16] objtool/powerpc: Enable objtool to be built on ppc Sathvika Vasireddy
2022-08-30 6:41 ` Christophe Leroy
2022-09-05 10:37 ` Naveen N. Rao
2023-02-04 8:19 ` Randy Dunlap
2023-02-04 8:21 ` Randy Dunlap
2023-02-04 8:30 ` Randy Dunlap
2023-02-04 11:55 ` Christophe Leroy
2023-02-04 13:10 ` Christophe Leroy
2023-02-04 15:47 ` Josh Poimboeuf
2022-09-01 9:32 ` Christophe Leroy
2022-09-01 15:11 ` Segher Boessenkool
2022-09-01 16:38 ` Christophe Leroy
2022-09-01 19:01 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 16/16] objtool/powerpc: Add --mcount specific implementation Sathvika Vasireddy
2022-08-30 6:44 ` Christophe Leroy
2022-08-31 12:50 ` Christophe Leroy
2022-08-31 17:51 ` Segher Boessenkool
2022-09-05 10:45 ` Naveen N. Rao
2022-09-05 20:43 ` Segher Boessenkool
2022-09-06 6:22 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxHB6VzfXYozAPEA@hirez.programming.kicks-ass.net \
--to=peterz@infradead$(echo .)org \
--cc=aik@ozlabs$(echo .)ru \
--cc=chenzhongjin@huawei$(echo .)com \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=jpoimboe@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mbenes@suse$(echo .)cz \
--cc=mingo@redhat$(echo .)com \
--cc=naveen.n.rao@linux$(echo .)vnet.ibm.com \
--cc=npiggin@gmail$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=sv@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox