From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: Christophe Leroy <christophe.leroy@csgroup•eu>
Cc: Michael Ellerman <mpe@ellerman•id.au>,
Madhavan Srinivasan <maddy@linux•ibm.com>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
Nicholas Piggin <npiggin@gmail•com>,
Naveen N Rao <naveen@kernel•org>
Subject: Re: [PATCH v2 1/1] powerpc/8xx: Drop legacy-of-mm-gpiochip.h header
Date: Fri, 13 Dec 2024 19:07:35 +0200 [thread overview]
Message-ID: <Z1xp1xwLXAvkKgwD@smile.fi.intel.com> (raw)
In-Reply-To: <991aee8b-fb10-4152-89fb-6ac542ee87c1@csgroup.eu>
On Fri, Dec 13, 2024 at 07:28:45AM +0100, Christophe Leroy wrote:
> Le 12/12/2024 à 17:24, Andy Shevchenko a écrit :
> > On Mon, Nov 18, 2024 at 03:10:09PM +0100, Christophe Leroy wrote:
> > > Le 18/11/2024 à 13:31, Andy Shevchenko a écrit :
> > > > Remove legacy-of-mm-gpiochip.h header file. The above mentioned
> > > > file provides an OF API that's deprecated. There is no agnostic
> > > > alternatives to it and we have to open code the logic which was
> > > > hidden behind of_mm_gpiochip_add_data(). Note, most of the GPIO
> > > > drivers are using their own labeling schemas and resource retrieval
> > > > that only a few may gain of the code deduplication, so whenever
> > > > alternative is appear we can move drivers again to use that one.
> > > >
> > > > As a side effect this change fixes a potential memory leak on
> > > > an error path, if of_mm_gpiochip_add_data() fails.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
> > >
> > > Reviewed-by: Christophe Leroy <christophe.leroy@csgroup•eu>
> >
> > Thanks, what's next?
>
> Next step is that Michael or Madhavan apply it I guess ?
Folks, do you have any comments? Can you apply this and we move forward towards
removing the legacy API from the kernel?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-12-13 17:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 12:31 [PATCH v2 1/1] powerpc/8xx: Drop legacy-of-mm-gpiochip.h header Andy Shevchenko
2024-11-18 14:10 ` Christophe Leroy
2024-12-12 16:24 ` Andy Shevchenko
2024-12-13 6:28 ` Christophe Leroy
2024-12-13 17:07 ` Andy Shevchenko [this message]
2024-12-13 18:01 ` Christophe Leroy
2024-12-14 22:18 ` Andy Shevchenko
2024-12-16 2:42 ` Madhavan Srinivasan
2025-01-01 9:08 ` Madhavan Srinivasan
2025-08-14 8:33 ` Christophe Leroy
2025-08-20 14:10 ` Andy Shevchenko
2025-11-24 15:10 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1xp1xwLXAvkKgwD@smile.fi.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=naveen@kernel$(echo .)org \
--cc=npiggin@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox